Bug 204326 - Fix load<16> on ARM64
Summary: Fix load<16> on ARM64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-18 15:24 PST by Robin Morisset
Modified: 2019-11-20 12:07 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2019-11-18 16:13 PST, Robin Morisset
no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2019-11-18 16:21 PST, Robin Morisset
no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2019-11-18 16:29 PST, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-11-18 15:24:45 PST
It was introduced in https://bugs.webkit.org/show_bug.cgi?id=202832, and Daniel Bates notified me of a bug in it.
More precisely, it calls ldr<16>, which calls CHECK_DATASIZE which in turns does an ASSERT(16 == 32 || 16 == 64);
I am still trying to see if I can just remove the assert (which looks plain wrong), or if there is a more serious problem here.
<rdar://problem/57297184> REGRESSION (r252422) CHECK_DATASIZE() fails loading docs.google.com
Comment 1 Robin Morisset 2019-11-18 16:13:18 PST
Created attachment 383802 [details]
Patch
Comment 2 Robin Morisset 2019-11-18 16:21:36 PST
Created attachment 383803 [details]
Patch
Comment 3 Robin Morisset 2019-11-18 16:29:38 PST
Created attachment 383805 [details]
Patch
Comment 4 Mark Lam 2019-11-18 16:46:13 PST
Comment on attachment 383805 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2019-11-20 12:06:59 PST
Comment on attachment 383805 [details]
Patch

Clearing flags on attachment: 383805

Committed r252699: <https://trac.webkit.org/changeset/252699>
Comment 6 WebKit Commit Bot 2019-11-20 12:07:01 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-20 12:07:21 PST
<rdar://problem/57368165>