Bug 204322 - Check if ITP is on before applying third-party cookie blocking
Summary: Check if ITP is on before applying third-party cookie blocking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-18 15:02 PST by John Wilander
Modified: 2019-11-18 22:30 PST (History)
2 users (show)

See Also:

Attachments
Patch (18.41 KB, patch)
2019-11-18 15:05 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (18.27 KB, patch)
2019-11-18 19:47 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-11-18 15:02:32 PST 
<rdar://problem/57120772>
Comment 1 John Wilander 2019-11-18 15:05:19 PST 
Created attachment 383795 [details]
Patch
Comment 2 John Wilander 2019-11-18 15:05:38 PST 
Comment on attachment 383795 [details]
Patch

Checking EWS before landing.
Comment 3 John Wilander 2019-11-18 16:06:18 PST 
Looking into test failure.
Comment 4 John Wilander 2019-11-18 19:39:24 PST 
Found the issue. Trunk uses a different WebsiteDataStore for the TestRunner and I must turn ITP on/off on that store. New patch coming up.
Comment 5 John Wilander 2019-11-18 19:47:06 PST 
Created attachment 383834 [details]
Patch
Comment 6 John Wilander 2019-11-18 19:49:16 PST 
Comment on attachment 383834 [details]
Patch

Again checking EWS before landing. The only change is for TestController::setStatisticsEnabled() to use TestController::websiteDataStore() in the call to WKWebsiteDataStoreSetResourceLoadStatisticsEnabled().
Comment 7 WebKit Commit Bot 2019-11-18 22:30:54 PST 
Comment on attachment 383834 [details]
Patch

Clearing flags on attachment: 383834

Committed r252623: <https://trac.webkit.org/changeset/252623>
Comment 8 WebKit Commit Bot 2019-11-18 22:30:56 PST 
All reviewed patches have been landed.  Closing bug.