Bug 204315 - results.webkit.org: Uncollapsed failures shouldn't include runs with no failures
Summary: results.webkit.org: Uncollapsed failures shouldn't include runs with no failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-18 13:34 PST by Jonathan Bedard
Modified: 2019-11-18 16:54 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.97 KB, patch)
2019-11-18 13:42 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (3.06 KB, patch)
2019-11-18 16:09 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-11-18 13:34:43 PST 
If a test run does not contain failures, when the user requests uncollapsed failures, we still include references to test runs with no failures.
Comment 1 Jonathan Bedard 2019-11-18 13:42:59 PST 
Created attachment 383785 [details]
Patch
Comment 2 Jonathan Bedard 2019-11-18 13:45:01 PST 
Looking to avoid something like this: https://results.webkit.org/api/failures/webkitpy-tests?id=252557&collapsed=False
Comment 3 Aakash Jain 2019-11-18 15:57:28 PST 
Comment on attachment 383785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383785&action=review

rs=me

> Tools/resultsdbpy/resultsdbpy/model/failure_context.py:190
> +                            if len(unpacked) > 2:

why 2? should we add a comment here indicating significance of 2 here.
Comment 4 Jonathan Bedard 2019-11-18 16:09:31 PST 
Created attachment 383801 [details]
Patch for landing
Comment 5 Jonathan Bedard 2019-11-18 16:09:59 PST 
Comment on attachment 383785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383785&action=review

>> Tools/resultsdbpy/resultsdbpy/model/failure_context.py:190
>> +                            if len(unpacked) > 2:
> 
> why 2? should we add a comment here indicating significance of 2 here.

Because our unpacked objects will always contain the keys uuid and start_time, even if there are no tests.
Comment 6 WebKit Commit Bot 2019-11-18 16:53:10 PST 
Comment on attachment 383801 [details]
Patch for landing

Clearing flags on attachment: 383801

Committed r252606: <https://trac.webkit.org/changeset/252606>
Comment 7 WebKit Commit Bot 2019-11-18 16:53:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-11-18 16:54:21 PST 
<rdar://problem/57304858>