RESOLVED FIXED 204315
results.webkit.org: Uncollapsed failures shouldn't include runs with no failures 
https://bugs.webkit.org/show_bug.cgi?id=204315
Summary results.webkit.org: Uncollapsed failures shouldn't include runs with no failures
Jonathan Bedard
Reported 2019-11-18 13:34:43 PST
If a test run does not contain failures, when the user requests uncollapsed failures, we still include references to test runs with no failures.
Attachments
Patch (2.97 KB, patch)
2019-11-18 13:42 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.06 KB, patch)
2019-11-18 16:09 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-11-18 13:42:59 PST
Created attachment 383785 [details] Patch
Jonathan Bedard
Comment 2 2019-11-18 13:45:01 PST
Looking to avoid something like this: https://results.webkit.org/api/failures/webkitpy-tests?id=252557&collapsed=False
Aakash Jain
Comment 3 2019-11-18 15:57:28 PST
Comment on attachment 383785 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383785&action=review rs=me > Tools/resultsdbpy/resultsdbpy/model/failure_context.py:190 > + if len(unpacked) > 2: why 2? should we add a comment here indicating significance of 2 here.
Jonathan Bedard
Comment 4 2019-11-18 16:09:31 PST
Created attachment 383801 [details] Patch for landing
Jonathan Bedard
Comment 5 2019-11-18 16:09:59 PST
Comment on attachment 383785 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383785&action=review >> Tools/resultsdbpy/resultsdbpy/model/failure_context.py:190 >> + if len(unpacked) > 2: > > why 2? should we add a comment here indicating significance of 2 here. Because our unpacked objects will always contain the keys uuid and start_time, even if there are no tests.
WebKit Commit Bot
Comment 6 2019-11-18 16:53:10 PST
Comment on attachment 383801 [details] Patch for landing Clearing flags on attachment: 383801 Committed r252606: <https://trac.webkit.org/changeset/252606>
WebKit Commit Bot
Comment 7 2019-11-18 16:53:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-11-18 16:54:21 PST
<rdar://problem/57304858>
Note You need to log in before you can comment on or make changes to this bug.