Bug 204309 - Clarify that OptionRange::operator=() is only used for initializing to 0 (i.e. state Uninitialized).
Summary: Clarify that OptionRange::operator=() is only used for initializing to 0 (i.e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-18 12:15 PST by Mark Lam
Modified: 2019-11-18 12:38 PST (History)
2 users (show)

See Also:

Attachments
proposed patch. (1.76 KB, patch)
2019-11-18 12:19 PST, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-11-18 12:15:29 PST 
...
Comment 1 Mark Lam 2019-11-18 12:19:22 PST 
Created attachment 383776 [details]
proposed patch.
Comment 2 Mark Lam 2019-11-18 12:22:14 PST 
Comment on attachment 383776 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=383776&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Clarify that OptionRange::operator=() is only used for initialized to 0 (i.e. state Uninitialized).

Will replace /initialized/initializing/.
Comment 3 Saam Barati 2019-11-18 12:22:31 PST 
Comment on attachment 383776 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=383776&action=review

> Source/JavaScriptCore/runtime/OptionsList.h:554
> +    OptionRange& operator= (int value)

no space
Comment 4 Mark Lam 2019-11-18 12:37:04 PST 
Thanks for the review.

(In reply to Saam Barati from comment #3)
> > Source/JavaScriptCore/runtime/OptionsList.h:554
> > +    OptionRange& operator= (int value)
> 
> no space

Fixed.

Landed in r252558: <http://trac.webkit.org/r252558>.
Comment 5 Radar WebKit Bug Importer 2019-11-18 12:38:16 PST 
<rdar://problem/57293275>