WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
204309
Clarify that OptionRange::operator=() is only used for initializing to 0 (i.e. state Uninitialized).
https://bugs.webkit.org/show_bug.cgi?id=204309
Summary
Clarify that OptionRange::operator=() is only used for initializing to 0 (i.e...
Mark Lam
Reported
2019-11-18 12:15:29 PST
...
Attachments
proposed patch.
(1.76 KB, patch)
2019-11-18 12:19 PST
,
Mark Lam
saam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2019-11-18 12:19:22 PST
Created
attachment 383776
[details]
proposed patch.
Mark Lam
Comment 2
2019-11-18 12:22:14 PST
Comment on
attachment 383776
[details]
proposed patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=383776&action=review
> Source/JavaScriptCore/ChangeLog:3 > + Clarify that OptionRange::operator=() is only used for initialized to 0 (i.e. state Uninitialized).
Will replace /initialized/initializing/.
Saam Barati
Comment 3
2019-11-18 12:22:31 PST
Comment on
attachment 383776
[details]
proposed patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=383776&action=review
> Source/JavaScriptCore/runtime/OptionsList.h:554 > + OptionRange& operator= (int value)
no space
Mark Lam
Comment 4
2019-11-18 12:37:04 PST
Thanks for the review. (In reply to Saam Barati from
comment #3
)
> > Source/JavaScriptCore/runtime/OptionsList.h:554 > > + OptionRange& operator= (int value) > > no space
Fixed. Landed in
r252558
: <
http://trac.webkit.org/r252558
>.
Radar WebKit Bug Importer
Comment 5
2019-11-18 12:38:16 PST
<
rdar://problem/57293275
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug