Bug 204303 - Delete unused visually non-empty methods from FrameView
Summary: Delete unused visually non-empty methods from FrameView
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
Keywords: InRadar
Depends on:
Reported: 2019-11-18 10:28 PST by Ben Nham
Modified: 2019-11-18 11:10 PST (History)
6 users (show)

See Also:

Patch (1.42 KB, patch)
2019-11-18 10:30 PST, Ben Nham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2019-11-18 10:28:38 PST
FrameView has some methods in its header (updateIsVisuallyNonEmpty and updateSignificantRenderedTextMilestoneIfNeeded) that used to be  part of the visually non-empty logic, but are no longer implemented. Delete them.
Comment 1 Ben Nham 2019-11-18 10:30:42 PST
Created attachment 383760 [details]
Comment 2 WebKit Commit Bot 2019-11-18 11:09:41 PST
Comment on attachment 383760 [details]

Clearing flags on attachment: 383760

Committed r252552: <https://trac.webkit.org/changeset/252552>
Comment 3 WebKit Commit Bot 2019-11-18 11:09:43 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-11-18 11:10:22 PST