Bug 204300 – [Cocoa] Add WKUIDelegate SPI to inform clients when a _WKInspector attaches to a WKWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Blaze Burg]

,

[Blaze Burg]

<rdar://problem/57136993>

[Blaze Burg]

Created attachment 383799 [details]
Patch

[Devin Rousso]

Comment on attachment 383799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383799&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:240
> +- (void)_webView:(WKWebView *)webView didAttachInspector:(_WKInspector *)inspector WK_API_AVAILABLE(macos(WK_MAC_TBA));
> +#endif // !TARGET_OS_IPHONE

Wouldn't it be more accurate to have this be in its own `#if TARGET_OS_MAC`?

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 383799 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383799&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:240
> > +- (void)_webView:(WKWebView *)webView didAttachInspector:(_WKInspector *)inspector WK_API_AVAILABLE(macos(WK_MAC_TBA));
> > +#endif // !TARGET_OS_IPHONE
> 
> Wouldn't it be more accurate to have this be in its own `#if TARGET_OS_MAC`?

• TARGET_OS_MAC is more like DARWIN, it includes "everything" macOS, iOS, tvOS, watchOS etc
• TARGET_OS_IPHONE is more like IOS_FAMILY or EMBEDDED for us. It includes iOS, tvOS, watchOS, etc.

TARGET_OS_OSX is the thing that only targets directly macOS, however we don't use that anywhere in WebKit yet (I assume for compatibility when building on older OSes). The norm in WebKit is to use !TARGET_OS_IPHONE right now.

[Blaze Burg]

Committed r252634: <https://trac.webkit.org/changeset/252634>