Bug 204287 - [Clipboard API] Add support for Clipboard.writeText()
Summary: [Clipboard API] Add support for Clipboard.writeText()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-17 19:40 PST by Wenson Hsieh
Modified: 2019-11-20 16:29 PST (History)
7 users (show)

See Also:

Attachments
Patch (15.54 KB, patch)
2019-11-17 20:13 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix GTK/WPE builds (15.71 KB, patch)
2019-11-17 20:15 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-11-17 19:40:12 PST 
Implement Clipboard.writeText().
Comment 1 Radar WebKit Bug Importer 2019-11-17 19:40:30 PST 
<rdar://problem/57270440>
Comment 2 Wenson Hsieh 2019-11-17 20:13:11 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2019-11-17 20:15:58 PST 
Created attachment 383725 [details]
Fix GTK/WPE builds
Comment 4 WebKit Commit Bot 2019-11-18 13:22:38 PST 
Comment on attachment 383725 [details]
Fix GTK/WPE builds

Clearing flags on attachment: 383725

Committed r252561: <https://trac.webkit.org/changeset/252561>
Comment 5 WebKit Commit Bot 2019-11-18 13:22:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2019-11-20 15:52:49 PST 
Comment on attachment 383725 [details]
Fix GTK/WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=383725&action=review

> Source/WebCore/Modules/async-clipboard/Clipboard.cpp:107
> +    if (!document || !frame || !shouldProceedWithClipboardWrite(*frame)) {

No need for the "!frame" check here.
Comment 7 Wenson Hsieh 2019-11-20 16:29:38 PST 
Comment on attachment 383725 [details]
Fix GTK/WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=383725&action=review

>> Source/WebCore/Modules/async-clipboard/Clipboard.cpp:107
>> +    if (!document || !frame || !shouldProceedWithClipboardWrite(*frame)) {
> 
> No need for the "!frame" check here.

Good catch — non-null document already implies non-null frame here. Fixed in r252718.