RESOLVED FIXED 204287
[Clipboard API] Add support for Clipboard.writeText() 
https://bugs.webkit.org/show_bug.cgi?id=204287
Summary [Clipboard API] Add support for Clipboard.writeText()
Wenson Hsieh
Reported 2019-11-17 19:40:12 PST
Implement Clipboard.writeText().
Attachments
Patch (15.54 KB, patch)
2019-11-17 20:13 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix GTK/WPE builds (15.71 KB, patch)
2019-11-17 20:15 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-17 19:40:30 PST
<rdar://problem/57270440>
Wenson Hsieh
Comment 2 2019-11-17 20:13:11 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2019-11-17 20:15:58 PST
Created attachment 383725 [details] Fix GTK/WPE builds
WebKit Commit Bot
Comment 4 2019-11-18 13:22:38 PST
Comment on attachment 383725 [details] Fix GTK/WPE builds Clearing flags on attachment: 383725 Committed r252561: <https://trac.webkit.org/changeset/252561>
WebKit Commit Bot
Comment 5 2019-11-18 13:22:39 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6 2019-11-20 15:52:49 PST
Comment on attachment 383725 [details] Fix GTK/WPE builds View in context: https://bugs.webkit.org/attachment.cgi?id=383725&action=review > Source/WebCore/Modules/async-clipboard/Clipboard.cpp:107 > + if (!document || !frame || !shouldProceedWithClipboardWrite(*frame)) { No need for the "!frame" check here.
Wenson Hsieh
Comment 7 2019-11-20 16:29:38 PST
Comment on attachment 383725 [details] Fix GTK/WPE builds View in context: https://bugs.webkit.org/attachment.cgi?id=383725&action=review >> Source/WebCore/Modules/async-clipboard/Clipboard.cpp:107 >> + if (!document || !frame || !shouldProceedWithClipboardWrite(*frame)) { > > No need for the "!frame" check here. Good catch — non-null document already implies non-null frame here. Fixed in r252718.
Note You need to log in before you can comment on or make changes to this bug.