Bug 204284 - [LFC] Pass in the content area to LayoutContext::layout
Summary: [LFC] Pass in the content area to LayoutContext::layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-17 07:10 PST by zalan
Modified: 2019-11-17 13:02 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.04 KB, patch)
2019-11-17 07:15 PST, zalan
koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-17 07:10:37 PST
The content area for the root is always pre-computed.
Comment 1 Radar WebKit Bug Importer 2019-11-17 07:10:56 PST
<rdar://problem/57262690>
Comment 2 zalan 2019-11-17 07:15:11 PST
Created attachment 383720 [details]
Patch
Comment 3 WebKit Commit Bot 2019-11-17 12:01:45 PST
Comment on attachment 383720 [details]
Patch

Rejecting attachment 383720 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 383720, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=383720&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=204284&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 383720 from bug 204284.
Fetching: https://bugs.webkit.org/attachment.cgi?id=383720
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date
W: 36b857a99b0b3616bddb1130712b6f08086ea732 and refs/remotes/origin/master differ, using rebase:
:040000 040000 dbeffd504d5ff0d22c92db500d7fc21315f4a996 98c2922e4554af7d03462f880f060cb2250e53e5 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date
W: 36b857a99b0b3616bddb1130712b6f08086ea732 and refs/remotes/origin/master differ, using rebase:
:040000 040000 dbeffd504d5ff0d22c92db500d7fc21315f4a996 98c2922e4554af7d03462f880f060cb2250e53e5 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/13262884
Comment 4 zalan 2019-11-17 13:02:55 PST
Committed r252533: <https://trac.webkit.org/changeset/252533>