https://trac.webkit.org/changeset/252455 broke the build:
Broke a layout-test on iOS (Requested by aakashja_ on #webkit).
This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Created attachment 383695 [details]
ROLLOUT of r252455
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes.
If you would like to land the rollout faster, you can use the following command:
webkit-patch land-attachment ATTACHMENT_ID
where ATTACHMENT_ID is the ID of this attachment.
Comment on attachment 383695 [details]
ROLLOUT of r252455
Clearing flags on attachment: 383695
Committed r252526: <https://trac.webkit.org/changeset/252526>
All reviewed patches have been landed. Closing bug.
*** Bug 204223 has been marked as a duplicate of this bug. ***
This rollout broke all ports...
../../Source/WebCore/animation/DocumentTimeline.cpp: In member function ‘void WebCore::DocumentTimeline::animationAcceleratedRunningStateDidChange(WebCore::WebAnimation&)’:
../../Source/WebCore/animation/DocumentTimeline.cpp:639:9: error: ‘shouldRunUpdateAnimationsAndSendEventsIgnoringSuspensionState’ was not declared in this scope
Reverted r252526 for reason:
broke iOS and mac builds
Committed r252527: <https://trac.webkit.org/changeset/252527>
*** Bug 204509 has been marked as a duplicate of this bug. ***
Created attachment 384362 [details]
imported/w3c/web-platform-tests/css/css-animations/Document-getAnimations.tentative.html is now failing, but that's most likely because it worked by pure magic before. Hopefully this will be an easy fix, looking into that now.
Created attachment 384380 [details]
Comment on attachment 384380 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=384380&action=review
> + static unsigned s_globalPosition = 0;
Use uint64_t. Hopefully we'll never have that many animations.
(In reply to Dean Jackson from comment #12)
> Comment on attachment 384380 [details]
> View in context:
> > Source/WebCore/animation/AnimationTimeline.cpp:77
> > + static unsigned s_globalPosition = 0;
> Use uint64_t. Hopefully we'll never have that many animations.
If we created one animation every nanosecond, which is a bit of stretch since we need at least a few CPU cycles to create & destroy one in the main thread, it takes like ~584 years (2^64/(10^9*3600*24*365.24)) to overflow a 64 bit unsigned integer. We can safely say an issue that arises after such a runtime horizon is outside the scope of the WebKit project.
Created attachment 384416 [details]
Committed r252911: <https://trac.webkit.org/changeset/252911>