Bug 204252 - Python 3: Support run-api-tests
Summary: Python 3: Support run-api-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-15 15:02 PST by Jonathan Bedard
Modified: 2019-11-18 17:52 PST (History)
6 users (show)

See Also:


Attachments
Patch (12.09 KB, patch)
2019-11-18 14:13 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (12.17 KB, patch)
2019-11-18 17:22 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-11-15 15:02:14 PST
run-api-tests should work with Python 3
Comment 1 Jonathan Bedard 2019-11-18 14:13:37 PST
Created attachment 383789 [details]
Patch
Comment 2 Dean Johnson 2019-11-18 16:44:11 PST
Comment on attachment 383789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383789&action=review

Looks good to me; unofficial r+.

> Tools/Scripts/webkitpy/api_tests/manager.py:185
> +        test_names = [test for test in test_names for _ in range(self._options.repeat_each)]

Long-standing bug here that this can blow up with a pretty high repeat_each count. Since test_names is stored as a list though, it shouldn't be any different than it was before.
Comment 3 Aakash Jain 2019-11-18 16:45:20 PST
rs=me
Comment 4 Jonathan Bedard 2019-11-18 17:11:48 PST
Comment on attachment 383789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383789&action=review

>> Tools/Scripts/webkitpy/api_tests/manager.py:185
>> +        test_names = [test for test in test_names for _ in range(self._options.repeat_each)]
> 
> Long-standing bug here that this can blow up with a pretty high repeat_each count. Since test_names is stored as a list though, it shouldn't be any different than it was before.

True, but if it does blow up, we wouldn't be able to store the results from the run in RAM anyways, so not sure how useful they would be.
Comment 5 Jonathan Bedard 2019-11-18 17:22:59 PST
Created attachment 383814 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-11-18 17:51:25 PST
Comment on attachment 383814 [details]
Patch for landing

Clearing flags on attachment: 383814

Committed r252616: <https://trac.webkit.org/changeset/252616>
Comment 7 WebKit Commit Bot 2019-11-18 17:51:26 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-11-18 17:52:17 PST
<rdar://problem/57306597>