Bug 204252 – Python 3: Support run-api-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

run-api-tests should work with Python 3

[Jonathan Bedard]

Created attachment 383789 [details]
Patch

[Dean Johnson]

Comment on attachment 383789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383789&action=review

Looks good to me; unofficial r+.

> Tools/Scripts/webkitpy/api_tests/manager.py:185
> +        test_names = [test for test in test_names for _ in range(self._options.repeat_each)]

Long-standing bug here that this can blow up with a pretty high repeat_each count. Since test_names is stored as a list though, it shouldn't be any different than it was before.

[Aakash Jain]

rs=me

[Jonathan Bedard]

Comment on attachment 383789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383789&action=review

>> Tools/Scripts/webkitpy/api_tests/manager.py:185
>> +        test_names = [test for test in test_names for _ in range(self._options.repeat_each)]
> 
> Long-standing bug here that this can blow up with a pretty high repeat_each count. Since test_names is stored as a list though, it shouldn't be any different than it was before.

True, but if it does blow up, we wouldn't be able to store the results from the run in RAM anyways, so not sure how useful they would be.

[Jonathan Bedard]

Created attachment 383814 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 383814 [details]
Patch for landing

Clearing flags on attachment: 383814

Committed r252616: <https://trac.webkit.org/changeset/252616>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57306597>