Bug 204244 - Rename InPlaceAbstractState's m_foundConstant to m_shouldTryConstantFolding.
Summary: Rename InPlaceAbstractState's m_foundConstant to m_shouldTryConstantFolding.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-15 13:50 PST by Mark Lam
Modified: 2019-11-15 14:11 PST (History)
2 users (show)

See Also:

Attachments
proposed patch. (29.22 KB, patch)
2019-11-15 13:56 PST, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-11-15 13:50:54 PST 
m_shouldTryConstantFolding is a more accurate description of what this flag really means i.e. that we may benefit from constant folding, and therefore, should attempt it.  It doesn't always  mean that we found constants to be folded.
Comment 1 Mark Lam 2019-11-15 13:56:25 PST 
Created attachment 383646 [details]
proposed patch.
Comment 2 Mark Lam 2019-11-15 14:10:58 PST 
Thanks for the review.  Landed in r252502: <http://trac.webkit.org/r252502>.
Comment 3 Radar WebKit Bug Importer 2019-11-15 14:11:20 PST 
<rdar://problem/57239831>