Bug 204236 – REGRESSION (r195080): prepare-ChangeLog does not emit function list for file paths that contain a space

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

The fix for bug #137982 broke function list generation for file paths that contain space characters (e.g. Folder/Another Folder With Spaces/A.m).

[Daniel Bates]

Why did bug #137982 break things? I explained in bug 137982, comment 6.

[Daniel Bates]

Created attachment 383631 [details]
Patch

[EWS Watchlist]

Comment on attachment 383631 [details]
Patch

Attachment 383631 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13259035

New failing tests:
animations/no-style-recalc-during-accelerated-animation.html

[EWS Watchlist]

Created attachment 383655 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Daniel Bates]

(In reply to Build Bot from comment #4)
> Created attachment 383655 [details]
> Archive of layout-test-results from ews214 for win-future
> 
> The attached test failures were seen while running run-webkit-tests on the
> win-ews.
> Bot: ews214  Port: win-future  Platform:
> CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit


^^^ Ignore. Patch doesn't affect tests.

[Daniel Bates]

Comment on attachment 383631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383631&action=review

> Tools/ChangeLog:11
> +        the unescape file path. Subsequent code would try to query these dictionaries to build up the

unescaped

[Blaze Burg]

Comment on attachment 383631 [details]
Patch

r=me

[Daniel Bates]

Created attachment 384639 [details]
To land

[Daniel Bates]

Committed r252991: <https://trac.webkit.org/changeset/252991>

[Radar WebKit Bug Importer]

<rdar://problem/57562442>