Bug 204236 - REGRESSION (r195080): prepare-ChangeLog does not emit function list for file paths that contain a space
Summary: REGRESSION (r195080): prepare-ChangeLog does not emit function list for file ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, Regression
Depends on: 137982
Blocks:
  Show dependency treegraph
 
Reported: 2019-11-15 11:17 PST by Daniel Bates
Modified: 2019-12-02 10:33 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.23 KB, patch)
2019-11-15 11:23 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews214 for win-future (14.31 MB, application/zip)
2019-11-15 15:06 PST, Build Bot
no flags Details
To land (2.22 KB, patch)
2019-12-02 10:32 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-11-15 11:17:19 PST
The fix for bug #137982 broke function list generation for file paths that contain space characters (e.g. Folder/Another Folder With Spaces/A.m).
Comment 1 Daniel Bates 2019-11-15 11:20:03 PST
Why did bug #137982 break things? I explained in bug 137982, comment 6.
Comment 2 Daniel Bates 2019-11-15 11:23:52 PST
Created attachment 383631 [details]
Patch
Comment 3 Build Bot 2019-11-15 15:06:01 PST
Comment on attachment 383631 [details]
Patch

Attachment 383631 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13259035

New failing tests:
animations/no-style-recalc-during-accelerated-animation.html
Comment 4 Build Bot 2019-11-15 15:06:04 PST
Created attachment 383655 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 Daniel Bates 2019-12-02 10:14:13 PST
(In reply to Build Bot from comment #4)
> Created attachment 383655 [details]
> Archive of layout-test-results from ews214 for win-future
> 
> The attached test failures were seen while running run-webkit-tests on the
> win-ews.
> Bot: ews214  Port: win-future  Platform:
> CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit


^^^ Ignore. Patch doesn't affect tests.
Comment 6 Daniel Bates 2019-12-02 10:15:58 PST
Comment on attachment 383631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383631&action=review

> Tools/ChangeLog:11
> +        the unescape file path. Subsequent code would try to query these dictionaries to build up the

unescaped
Comment 7 Brian Burg 2019-12-02 10:25:19 PST
Comment on attachment 383631 [details]
Patch

r=me
Comment 8 Daniel Bates 2019-12-02 10:32:21 PST
Created attachment 384639 [details]
To land
Comment 9 Daniel Bates 2019-12-02 10:32:59 PST
Committed r252991: <https://trac.webkit.org/changeset/252991>
Comment 10 Radar WebKit Bug Importer 2019-12-02 10:33:23 PST
<rdar://problem/57562442>