Bug 204234 – Add more release logging for network load restarts

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Add more release logging for network load restarts.

[Chris Dumez]

Created attachment 383627 [details]
Patch

[youenn fablet]

Comment on attachment 383627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383627&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:1265
> +        RELEASE_LOG_IF_ALLOWED("serviceWorkerDidNotHandle: (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ") Restarting network load", m_parameters.webPageID.toUInt64(), m_parameters.webFrameID.toUInt64(), m_parameters.identifier);

Isn’t it a bit redundant with serviceworkerfetchtask logging?

[Chris Dumez]

Comment on attachment 383627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383627&action=review

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:1265
>> +        RELEASE_LOG_IF_ALLOWED("serviceWorkerDidNotHandle: (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ") Restarting network load", m_parameters.webPageID.toUInt64(), m_parameters.webFrameID.toUInt64(), m_parameters.identifier);
> 
> Isn’t it a bit redundant with serviceworkerfetchtask logging?

I really want to see the call sites of restartNetworkLoad().

[youenn fablet]

I believe this specific didNotHandle is logged twice, once in NetworkResouceLoader and once in ServiceWorkerFetchTask. If so, this seems excessive.

[WebKit Commit Bot]

Comment on attachment 383627 [details]
Patch

Clearing flags on attachment: 383627

Committed r252510: <https://trac.webkit.org/changeset/252510>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57243555>