Bug 204222 - [ews] Perform validation of patch before retrying JSC tests
Summary: [ews] Perform validation of patch before retrying JSC tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-15 04:11 PST by Aakash Jain
Modified: 2019-11-19 08:47 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.22 KB, patch)
2019-11-15 04:14 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-15 04:11:44 PST
JSC tests takes a while to run (~45 mins). In case of failure, we retry the tests, and if failures are noticed in retry as well, then we un-apply the patch, build the ToT and run the tests again. All these steps might take a while to complete. 

Meanwhile the patch might get obsolete or r-. EWS should not continue to process such patches, as it would be wasteful. We should check the patch status before running any time-consuming step (like running tests, or building without patch). 

We did similar thing for layout and api tests in https://trac.webkit.org/changeset/252037/webkit
Comment 1 Aakash Jain 2019-11-15 04:14:05 PST
Created attachment 383612 [details]
Patch
Comment 2 WebKit Commit Bot 2019-11-15 08:39:32 PST
Comment on attachment 383612 [details]
Patch

Clearing flags on attachment: 383612

Committed r252485: <https://trac.webkit.org/changeset/252485>
Comment 3 WebKit Commit Bot 2019-11-15 08:39:33 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-11-15 08:40:20 PST
<rdar://problem/57228467>