Bug 204213 - Fix getTotalLength() and getPointAtLength() for optimized rect and ellipse renderers
Summary: Fix getTotalLength() and getPointAtLength() for optimized rect and ellipse re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 200143
  Show dependency tree / graph
 
Reported: 2019-11-14 17:02 PST by Said Abou-Hallawa
Modified: 2019-11-18 13:46 PST (History)
15 users (show)

See Also:

Attachments
Patch (9.02 KB, patch)
2019-11-14 17:18 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (55.58 KB, patch)
2019-11-16 07:21 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-11-14 17:02:41 PST 
Since these functions were added in r231955, they do not handle the case of optimized rect and ellipse renderers. For these renderers, we do not create a path to draw the simple rect or ellipse. Instead we call the rect or ellipse functions directly from the GraphicsContext.

But for getTotalLength() and getPointAtLength(), we need to create a temporary Path from the SVGElement then use it to answer the questions of these functions and finally delete it.
Comment 1 Said Abou-Hallawa 2019-11-14 17:18:27 PST 
Created attachment 383589 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-11-16 07:21:07 PST 
Created attachment 383696 [details]
Patch
Comment 3 WebKit Commit Bot 2019-11-18 13:45:49 PST 
Comment on attachment 383696 [details]
Patch

Clearing flags on attachment: 383696

Committed r252563: <https://trac.webkit.org/changeset/252563>
Comment 4 WebKit Commit Bot 2019-11-18 13:45:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-11-18 13:46:21 PST 
<rdar://problem/57296135>