diff --git a/Tools/Scripts/webkitpy/common/config/committers.py b/Tools/Scripts/webkitpy/common/config/committers.py index 0d63ff67c1453120169b4b8652b97fbd15aee6df..df620d5594521e71a298207592b76d75ec9dad44 100644 --- a/Tools/Scripts/webkitpy/common/config/committers.py +++ b/Tools/Scripts/webkitpy/common/config/committers.py @@ -32,6 +32,7 @@ import fnmatch import json import sys +import time from functools import reduce from webkitpy.common.editdistance import edit_distance @@ -194,7 +195,10 @@ class CommitterList(object): if committers or reviewers or contributors: self.load_test_data(committers, reviewers, contributors) else: + start = time.time() self.load_json() + end = time.time() + print 'Loading committers took {}ms'.format(1000 * (end - start)) self._contributors_by_name = {} self._accounts_by_email = {} Loading committers took 11.5311145782ms Loading committers took 11.4798545837ms Loading committers took 9.89007949829ms Loading committers took 10.3440284729ms
Created attachment 383622 [details] Patch
Unlike some of our other performance issues in webkitpy, this one is caused by doing something pretty blatantly against Python best practices that is also a very easy fix.
Comment on attachment 383622 [details] Patch Clearing flags on attachment: 383622 Committed r252489: <https://trac.webkit.org/changeset/252489>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57230884>