Bug 204207 - Publish JavaScriptCore as Clang module
Summary: Publish JavaScriptCore as Clang module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-14 16:04 PST by Chris Polcyn
Modified: 2019-11-18 10:56 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.09 KB, patch)
2019-11-14 16:10 PST, Chris Polcyn 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Polcyn 2019-11-14 16:04:37 PST 
Publish JavaScriptCore as Clang module
Comment 1 Chris Polcyn 2019-11-14 16:10:47 PST 
Created attachment 383582 [details]
Patch
Comment 2 Keith Miller 2019-11-14 16:36:19 PST 
Do Clang modules support exporting macros? I'm assuming yes but, IIRC, C++ modules don't.
Comment 3 Chris Polcyn 2019-11-14 20:23:24 PST 
(In reply to Keith Miller from comment #2)
> Do Clang modules support exporting macros? I'm assuming yes but, IIRC, C++
> modules don't.

Yes, you can read about it here:
https://clang.llvm.org/docs/Modules.html#macros
Comment 4 Keith Miller 2019-11-14 22:11:41 PST 
Comment on attachment 383582 [details]
Patch

I see, that makes sense. r=me.
Comment 5 Keith Miller 2019-11-14 22:12:52 PST 
Do you have commit privileges? If not, I can do it for you.
Comment 6 Chris Polcyn 2019-11-18 09:52:46 PST 
(In reply to Keith Miller from comment #5)
> Do you have commit privileges? If not, I can do it for you.

I assume I don't have commit privileges as it's my first time contributing here. If you want to do it that would be great. Thanks!
Comment 7 WebKit Commit Bot 2019-11-18 10:55:26 PST 
Comment on attachment 383582 [details]
Patch

Clearing flags on attachment: 383582

Committed r252551: <https://trac.webkit.org/changeset/252551>
Comment 8 WebKit Commit Bot 2019-11-18 10:55:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-11-18 10:56:17 PST 
<rdar://problem/57289332>