Bug 204200 - The CSSParser should not consume negative or unit-less lengths for the SVG properties 'r', 'rx' and 'ry'
Summary: The CSSParser should not consume negative or unit-less lengths for the SVG pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 200143
  Show dependency treegraph
 
Reported: 2019-11-14 12:30 PST by Said Abou-Hallawa
Modified: 2019-11-14 14:46 PST (History)
12 users (show)

See Also:


Attachments
Patch (13.33 KB, patch)
2019-11-14 12:41 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-11-14 12:30:05 PST
SVGEllipseElement::parseAttribute() and SVGCircleElement::parseAttribute() both forbid negative values for these properties. The CSSParser should be consistent with setting these properties through setAttribute().

The type of these properties is <length-percentage>, https://www.w3.org/TR/css-values/#typedef-length-percentage, which requires specifying the unit if it's a length.
Comment 1 Said Abou-Hallawa 2019-11-14 12:41:20 PST
Created attachment 383570 [details]
Patch
Comment 2 WebKit Commit Bot 2019-11-14 14:45:21 PST
Comment on attachment 383570 [details]
Patch

Clearing flags on attachment: 383570

Committed r252467: <https://trac.webkit.org/changeset/252467>
Comment 3 WebKit Commit Bot 2019-11-14 14:45:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-11-14 14:46:18 PST
<rdar://problem/57205640>