Bug 204194 - Automation: scrollIntoView should do nothing if element is visible
Summary: Automation: scrollIntoView should do nothing if element is visible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-14 01:30 PST by Carlos Garcia Campos
Modified: 2019-11-19 01:01 PST (History)
12 users (show)

See Also:


Attachments
Patch (2.85 KB, patch)
2019-11-14 01:37 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (14.08 MB, application/zip)
2019-11-14 03:15 PST, EWS Watchlist
no flags Details
Patch (15.90 KB, patch)
2019-11-18 13:14 PST, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-11-14 01:30:47 PST
Even if it's partially visible, see https://w3c.github.io/webdriver/#dfn-scrolls-into-view This is causing several tests failures:


imported/w3c/webdriver/tests/element_click/scroll_into_view.py::test_partially_visible_does_not_scroll[9]
imported/w3c/webdriver/tests/element_click/scroll_into_view.py::test_partially_visible_does_not_scroll[8]
imported/w3c/webdriver/tests/element_click/scroll_into_view.py::test_partially_visible_does_not_scroll[7]
imported/w3c/webdriver/tests/element_click/scroll_into_view.py::test_partially_visible_does_not_scroll[6]
imported/w3c/webdriver/tests/element_click/scroll_into_view.py::test_partially_visible_does_not_scroll[5]
imported/w3c/webdriver/tests/element_click/scroll_into_view.py::test_partially_visible_does_not_scroll[4]
imported/w3c/webdriver/tests/element_click/scroll_into_view.py::test_partially_visible_does_not_scroll[3]
imported/w3c/webdriver/tests/element_click/scroll_into_view.py::test_partially_visible_does_not_scroll[2]
imported/w3c/webdriver/tests/element_click/scroll_into_view.py::test_partially_visible_does_not_scroll[1]
Comment 1 Carlos Garcia Campos 2019-11-14 01:37:16 PST
Created attachment 383548 [details]
Patch
Comment 2 EWS Watchlist 2019-11-14 03:15:11 PST
Comment on attachment 383548 [details]
Patch

Attachment 383548 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13253947

New failing tests:
http/tests/misc/repeat-open-cancel.html
Comment 3 EWS Watchlist 2019-11-14 03:15:13 PST
Created attachment 383551 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Carlos Garcia Campos 2019-11-18 00:40:46 PST
Committed r252539: <https://trac.webkit.org/changeset/252539>
Comment 5 Radar WebKit Bug Importer 2019-11-18 00:41:21 PST
<rdar://problem/57274949>
Comment 6 Andres Gonzalez 2019-11-18 13:14:16 PST
Reopening to attach new patch.
Comment 7 Andres Gonzalez 2019-11-18 13:14:18 PST
Created attachment 383780 [details]
Patch
Comment 8 Andres Gonzalez 2019-11-18 13:16:57 PST
Ignore this patch, uploaded to wrong bug.