Bug 204193 – Import secure cookie tests from WPT

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Patrick Griffis]

Import secure cookie tests from WPT

[Patrick Griffis]

Created attachment 383547 [details]
Patch

[Patrick Griffis]

Created attachment 383550 [details]
Patch

[Patrick Griffis]

The mac failures are from unrelated tests.

[Carlos Alberto Lopez Perez]

(In reply to Patrick Griffis from comment #3)
> The mac failures are from unrelated tests.

I don't think they are unrelated.

On this patch you are also importing imported/w3c/web-platform-tests/cookies/resources and it seems other WPT tests have resources pointing to /cookies/resources

Like, for example the one gives failure.

Which is not failing in reality.. now is passing thanks to this resources dir you are adding, but the expectation for it has a Fail line. You have to update the expectation for this test that now pass so the EWS doesn't complain.

[Carlos Alberto Lopez Perez]

https://ews-build.webkit.org/results/macOS-High-Sierra-Release-WK2-Tests-EWS/r383550-7168/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies-diff.txt

[Patrick Griffis]

Created attachment 383591 [details]
Patch

[Patrick Griffis]

Created attachment 383600 [details]
Patch

[EWS Watchlist]

Comment on attachment 383600 [details]
Patch

Attachment 383600 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13257834

New failing tests:
animations/no-style-recalc-during-accelerated-animation.html

[EWS Watchlist]

Created attachment 383606 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Patrick Griffis]

Created attachment 383742 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 383742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383742&action=review

> LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies-expected.txt:6
>  
>  PASS Image should not load 
>  PASS Violation report status OK. 
> -FAIL Test report cookies. assert_true: Report should contain cookie: cspViolationReportCookie2 expected true got false
> +PASS Test report cookies. 
>  

It seems this expectation update is not valid for ios-wk2 for some reason.

For ios-wk2 the new expectation is this one according to the EWS: https://ews-build.webkit.org/results/iOS-13-Simulator-WK2-Tests-EWS/r383742-5079/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies-actual.txt

See: https://ews-build.webkit.org/results/iOS-13-Simulator-WK2-Tests-EWS/r383742-5079/results.html

I suggest adding a new platform expected file for ios-wk2 (I guess under LayoutTests/platform/ios-simulator-wk2) to make the EWS happy.

[Patrick Griffis]

Created attachment 385179 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 385179 [details]
Patch

r=me
Patch looks good and EWS all green!

[WebKit Commit Bot]

Comment on attachment 385179 [details]
Patch

Clearing flags on attachment: 385179

Committed r253312: <https://trac.webkit.org/changeset/253312>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57777761>