Bug 204159 – Use SecTrustEvaluateWithError instead of SecTrustEvaluate where available

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Use SecTrustEvaluateWithError instead of SecTrustEvaluate where available

[Alex Christensen]

Created attachment 383459 [details]
Patch

[Alex Christensen]

<rdar://problem/45894288>

[Darin Adler]

Comment on attachment 383459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383459&action=review

> Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:101
> +        bool success = SecTrustEvaluateWithError(trust, &error);

This will leak the CFErrorRef. Note that the error argument is marked CF_RETURNS_RETAINED that indicates it’s the caller’s responsibility to release.

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:938
> +        bool success = SecTrustEvaluateWithError(trust, &error);

Ditto.

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:947
> +        infoDictionary = [(__bridge NSDictionary *)SecTrustCopyInfo(trust) autorelease];

Not important, but a side note. This line is just re-indented and this is not new code, but I would write this instead:

    infoDictionary = CFBridgingRelease(SecTrustCopyInfo(trust));

[Alex Christensen]

Created attachment 383599 [details]
Patch

[Alex Christensen]

Turns out having an error and returning false are the same, and we do nothing with the error, so I'm just passing nullptr to not receive the error.

[WebKit Commit Bot]

Comment on attachment 383599 [details]
Patch

Clearing flags on attachment: 383599

Committed r252595: <https://trac.webkit.org/changeset/252595>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.