Bug 20415 – Support editing DOM properties and scope variables

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

We need to support editing of DOM properties and scope variables whole paused in the debugger.

[Timothy Hatcher]

Created attachment 22864 [details]
Proposed patch

[Kevin McCullough]

Comment on attachment 22864 [details]
Proposed patch

in WebInspector.ObjectPropertyTreeElement.prototype line 202 hasChildren is restored, but update() will restore the hasChildren variable so it doesn't need to be in the context at all.

Line 193: Why does editingEnded take a context? It's not used.

Line 226 "the everything"

In treeoutline.js line 560 I do not understand why you are comparing what you are.  And should we even call insertBefore if nextSibling is null?

[Keishi Hattori]

This is cool. Maybe some kind of magic variable that points to the previous value and some command line api stuff would be useful?

[Timothy Hatcher]

(In reply to comment #2)
> (From update of attachment 22864 [details] [edit])
> in WebInspector.ObjectPropertyTreeElement.prototype line 202 hasChildren is
> restored, but update() will restore the hasChildren variable so it doesn't need
> to be in the context at all.

Fixed.

> Line 193: Why does editingEnded take a context? It's not used.

Changed this, it now uses the context since I moved some code.

> Line 226 "the everything"

Fixed.

> In treeoutline.js line 560 I do not understand why you are comparing what you
> are.  And should we even call insertBefore if nextSibling is null?

If the nextSibling's parentNode is different than the parent we are about to insert too, we need to use null for the next sibling otherwise you get a DOM exception 8. And calling insertBefore with null is the same as appendChild, so thats what we want.

[Kevin McCullough]

Comment on attachment 22864 [details]
Proposed patch

After Tim's changes

[Timothy Hatcher]

Landed in r35835.