[Win][DumpRenderTree][WebKitTestRunner] eventSender.keyDown should support function keys fast/events/keydown-function-keys.html is failing for AppleWin and WinCairo ports.
Created attachment 383440 [details] Patch
Comment on attachment 383440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383440&action=review > Tools/DumpRenderTree/win/EventSender.cpp:465 > + // Some keys need to turn on KF_EXTENDED explicitly This is a hack to work around a bug of MapVirtualKey and MapVirtualKeyEx doesn't work as expected. MapVirtualKey(), GetKeyNameText(), and a story of how to get proper names for the arrow keys - setnode.com http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/ http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/#comment-1104594462 > Even using MapVirtualKeyEx() doesn't make MAPVK_VK_TO_VSC_EX behave the way the docs seem to imply.
Comment on attachment 383440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383440&action=review r=me >> Tools/DumpRenderTree/win/EventSender.cpp:465 >> + // Some keys need to turn on KF_EXTENDED explicitly > > This is a hack to work around a bug of MapVirtualKey and MapVirtualKeyEx doesn't work as expected. > > MapVirtualKey(), GetKeyNameText(), and a story of how to get proper names for the arrow keys - setnode.com > http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/ > > http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/#comment-1104594462 Perhaps this info should be added to the ChangeLog?
Comment on attachment 383440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383440&action=review >>> Tools/DumpRenderTree/win/EventSender.cpp:465 >>> + // Some keys need to turn on KF_EXTENDED explicitly >> >> This is a hack to work around a bug of MapVirtualKey and MapVirtualKeyEx doesn't work as expected. >> >> MapVirtualKey(), GetKeyNameText(), and a story of how to get proper names for the arrow keys - setnode.com >> http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/ >> >> http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/#comment-1104594462 > > Perhaps this info should be added to the ChangeLog? Will do.
Created attachment 383531 [details] Patch for landing
Committed r252441: <https://trac.webkit.org/changeset/252441>
<rdar://problem/57176065>