Bug 204131 – AXObjectCache::rootObject should generate the isolated tree.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

AXObjectCache::rootObject should generate the isolated tree.

[Andres Gonzalez]

Created attachment 383404 [details]
Patch

[Andres Gonzalez]

Created attachment 383450 [details]
Patch

[chris fleizach]

Comment on attachment 383450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383450&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, no change in functionality.

can you put a description of the changes here for what's being accomplished

> Source/WebCore/accessibility/AXObjectCache.cpp:674
> +    if (!clientSupportsIsolatedTree())

can we separate the isolated tree stuff into a separate function so we can write

if (clientSupportsIsloatedTree()
   return isolateTreeRootObjet()
else
    getOrCreate(m_document.view());

[Andres Gonzalez]

Created attachment 383460 [details]
Patch

[chris fleizach]

Comment on attachment 383460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383460&action=review

> Source/WebCore/accessibility/AXObjectCache.h:198
> +    Ref<AXIsolatedTree> generateIsolatedTree(PageIdentifier);

ERROR: Source/WebCore/accessibility/AXObjectCache.h:198:  'generateIsolatedTree' is incorrectly named. It should be named 'protector' or 'protectedPageIdentifier'.  [readability/naming/protected] [4]
Total errors found: 1 in 8 files
program finished with exit code 1

[chris fleizach]

Comment on attachment 383460 [details]
Patch

I believe that style checker is wrong. shouldn't apply to function names

[Andres Gonzalez]

(In reply to chris fleizach from comment #5)
> Comment on attachment 383460 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383460&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.h:198
> > +    Ref<AXIsolatedTree> generateIsolatedTree(PageIdentifier);
> 
> ERROR: Source/WebCore/accessibility/AXObjectCache.h:198: 
> 'generateIsolatedTree' is incorrectly named. It should be named 'protector'
> or 'protectedPageIdentifier'.  [readability/naming/protected] [4]
> Total errors found: 1 in 8 files
> program finished with exit code 1

This is a style checker script bug that is confusing a method declaration with a variable.

[WebKit Commit Bot]

Comment on attachment 383460 [details]
Patch

Clearing flags on attachment: 383460

Committed r252417: <https://trac.webkit.org/changeset/252417>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57160071>