Bug 204131 - AXObjectCache::rootObject should generate the isolated tree.
Summary: AXObjectCache::rootObject should generate the isolated tree.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-12 16:32 PST by Andres Gonzalez
Modified: 2019-11-13 11:01 PST (History)
10 users (show)

See Also:

Attachments
Patch (13.16 KB, patch)
2019-11-12 16:42 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (14.47 KB, patch)
2019-11-13 05:35 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (15.49 KB, patch)
2019-11-13 08:52 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2019-11-12 16:32:24 PST 
AXObjectCache::rootObject should generate the isolated tree.
Comment 1 Andres Gonzalez 2019-11-12 16:42:02 PST 
Created attachment 383404 [details]
Patch
Comment 2 Andres Gonzalez 2019-11-13 05:35:39 PST 
Created attachment 383450 [details]
Patch
Comment 3 chris fleizach 2019-11-13 07:49:13 PST 
Comment on attachment 383450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383450&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, no change in functionality.

can you put a description of the changes here for what's being accomplished

> Source/WebCore/accessibility/AXObjectCache.cpp:674
> +    if (!clientSupportsIsolatedTree())

can we separate the isolated tree stuff into a separate function so we can write

if (clientSupportsIsloatedTree()
   return isolateTreeRootObjet()
else
    getOrCreate(m_document.view());
Comment 4 Andres Gonzalez 2019-11-13 08:52:04 PST 
Created attachment 383460 [details]
Patch
Comment 5 chris fleizach 2019-11-13 09:27:55 PST 
Comment on attachment 383460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383460&action=review

> Source/WebCore/accessibility/AXObjectCache.h:198
> +    Ref<AXIsolatedTree> generateIsolatedTree(PageIdentifier);

ERROR: Source/WebCore/accessibility/AXObjectCache.h:198:  'generateIsolatedTree' is incorrectly named. It should be named 'protector' or 'protectedPageIdentifier'.  [readability/naming/protected] [4]
Total errors found: 1 in 8 files
program finished with exit code 1
Comment 6 chris fleizach 2019-11-13 10:19:56 PST 
Comment on attachment 383460 [details]
Patch

I believe that style checker is wrong. shouldn't apply to function names
Comment 7 Andres Gonzalez 2019-11-13 10:38:52 PST 
(In reply to chris fleizach from comment #5)
> Comment on attachment 383460 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383460&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.h:198
> > +    Ref<AXIsolatedTree> generateIsolatedTree(PageIdentifier);
> 
> ERROR: Source/WebCore/accessibility/AXObjectCache.h:198: 
> 'generateIsolatedTree' is incorrectly named. It should be named 'protector'
> or 'protectedPageIdentifier'.  [readability/naming/protected] [4]
> Total errors found: 1 in 8 files
> program finished with exit code 1

This is a style checker script bug that is confusing a method declaration with a variable.
Comment 8 WebKit Commit Bot 2019-11-13 11:00:27 PST 
Comment on attachment 383460 [details]
Patch

Clearing flags on attachment: 383460

Committed r252417: <https://trac.webkit.org/changeset/252417>
Comment 9 WebKit Commit Bot 2019-11-13 11:00:29 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-11-13 11:01:21 PST 
<rdar://problem/57160071>