Bug 204130 - Cleanup old UIKit Staging
Summary: Cleanup old UIKit Staging
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
Keywords: InRadar
Depends on:
Reported: 2019-11-12 16:22 PST by Megan Gardner
Modified: 2019-11-17 17:13 PST (History)
6 users (show)

See Also:

Patch (8.00 KB, patch)
2019-11-12 16:24 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-11-12 16:22:36 PST
Cleanup old UIKit Staging
Comment 1 Megan Gardner 2019-11-12 16:24:39 PST
Created attachment 383401 [details]
Comment 2 WebKit Commit Bot 2019-11-13 15:05:08 PST
Comment on attachment 383401 [details]

Clearing flags on attachment: 383401

Committed r252434: <https://trac.webkit.org/changeset/252434>
Comment 3 WebKit Commit Bot 2019-11-13 15:05:09 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-11-13 15:06:04 PST
Comment 5 Alexey Proskuryakov 2019-11-17 16:57:33 PST
Comment on attachment 383401 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=383401&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:-1112
> -@interface UIWebGeolocationPolicyDecider (Staging_25963823)
> -- (void)decidePolicyForGeolocationRequestFromOrigin:(id)securityOrigin requestingURL:(NSURL *)requestingURL view:(UIView *)view listener:(id)listener;
> -@end

Roy pointed out that this broke internal build. This declaration is now only compiled in open source builds - and this method doesn't actually exist.

Code that uses this variant of decidePolicyForGeolocationRequestFromOrigin has a respondsToSelector check, so it is dead code. May be some kind of mistake in the patch that added this, rolling back for now.
Comment 6 Alexey Proskuryakov 2019-11-17 17:08:40 PST
Ugh, there were a lot of patches touching this header later, all of which would have to be rolled back.

Attempted a build fix in http://trac.webkit.org/r252535 - but someone (i.e. thorton) needs to take a look at what the intent of this code was originally.
Comment 7 Alexey Proskuryakov 2019-11-17 17:13:39 PST
No, I see what happened better now. Trying a different build fix in http://trac.webkit.org/r252536.