Bug 204130 – Cleanup old UIKit Staging

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Cleanup old UIKit Staging

[Megan Gardner]

Created attachment 383401 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 383401 [details]
Patch

Clearing flags on attachment: 383401

Committed r252434: <https://trac.webkit.org/changeset/252434>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57169789>

[Alexey Proskuryakov]

Comment on attachment 383401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383401&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:-1112
> -@interface UIWebGeolocationPolicyDecider (Staging_25963823)
> -- (void)decidePolicyForGeolocationRequestFromOrigin:(id)securityOrigin requestingURL:(NSURL *)requestingURL view:(UIView *)view listener:(id)listener;
> -@end

Roy pointed out that this broke internal build. This declaration is now only compiled in open source builds - and this method doesn't actually exist.

Code that uses this variant of decidePolicyForGeolocationRequestFromOrigin has a respondsToSelector check, so it is dead code. May be some kind of mistake in the patch that added this, rolling back for now.

[Alexey Proskuryakov]

Ugh, there were a lot of patches touching this header later, all of which would have to be rolled back.

Attempted a build fix in http://trac.webkit.org/r252535 - but someone (i.e. thorton) needs to take a look at what the intent of this code was originally.

[Alexey Proskuryakov]

No, I see what happened better now. Trying a different build fix in http://trac.webkit.org/r252536.