Bug 204124 - [JSC] JSC GC relies on CodeBlock is not PreciseAllocation
Summary: [JSC] JSC GC relies on CodeBlock is not PreciseAllocation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 201908
Blocks: 204039
  Show dependency tree / graph
 
Reported: 2019-11-12 12:54 PST by Yusuke Suzuki
Modified: 2019-11-12 17:40 PST (History)
7 users (show)

See Also:

Attachments
Patch (23.03 KB, patch)
2019-11-12 13:52 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (25.21 KB, patch)
2019-11-12 16:40 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-11-12 12:54:29 PST 
...
Comment 1 Yusuke Suzuki 2019-11-12 13:23:54 PST 
For now, we disable lower-tier-cells for CodeBlock.
Comment 2 Radar WebKit Bug Importer 2019-11-12 13:34:25 PST 
<rdar://problem/57128580>
Comment 3 Yusuke Suzuki 2019-11-12 13:35:06 PST 
<rdar://problem/57067238>
Comment 4 Yusuke Suzuki 2019-11-12 13:52:38 PST 
Created attachment 383380 [details]
Patch
Comment 5 Yusuke Suzuki 2019-11-12 16:40:22 PST 
Created attachment 383403 [details]
Patch
Comment 6 Yusuke Suzuki 2019-11-12 16:40:40 PST 
Small refactoring is done.
Comment 7 Yusuke Suzuki 2019-11-12 16:44:12 PST 
Comment on attachment 383403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383403&action=review

> Source/JavaScriptCore/heap/IsoSubspacePerVM.cpp:33
>  class IsoSubspacePerVM::AutoremovingIsoSubspace : public IsoSubspace {

I strongly want to remove IsoSubspacePerVM anyway.
Comment 8 Yusuke Suzuki 2019-11-12 17:40:40 PST 
Committed r252385: <https://trac.webkit.org/changeset/252385>