Bug 204122 - Use toLength() and getIndexQuickly() in JSON.stringify
Summary: Use toLength() and getIndexQuickly() in JSON.stringify
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-12 12:02 PST by Alexey Shvayka
Modified: 2019-11-14 14:01 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2019-11-12 12:23 PST, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2019-11-12 12:02:12 PST 
Use toLength() and getIndexQuickly() in JSON.stringify
Comment 1 Alexey Shvayka 2019-11-12 12:23:56 PST 
Created attachment 383370 [details]
Patch
Comment 2 Alexey Shvayka 2019-11-12 12:51:11 PST 
Style EWS fails because of

  RETURN_IF_EXCEPTION(scope, ); // <= that space,

which is a common pattern.

Cold runs, only results with low measurement error, --outer 8:

                                      rev. 252354             patch

json-stringify-array-replacer      350.7169+-0.9911      263.3854+-2.2296
json-stringify-empty-array         188.0573+-1.2934      189.5053+-1.4060
Comment 3 Yusuke Suzuki 2019-11-14 13:15:39 PST 
Comment on attachment 383370 [details]
Patch

Nice, r=me
Comment 4 WebKit Commit Bot 2019-11-14 14:00:06 PST 
Comment on attachment 383370 [details]
Patch

Clearing flags on attachment: 383370

Committed r252464: <https://trac.webkit.org/changeset/252464>
Comment 5 WebKit Commit Bot 2019-11-14 14:00:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-14 14:01:25 PST 
<rdar://problem/57203266>