Bug 204101 - Convert CSSPrimitiveValue::UnitType to an enum class, and cleanup
Summary: Convert CSSPrimitiveValue::UnitType to an enum class, and cleanup
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2019-11-11 22:09 PST by Simon Fraser (smfr)
Modified: 2019-11-12 21:01 PST (History)
30 users (show)

See Also:

Patch (332.82 KB, patch)
2019-11-11 22:12 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (14.35 MB, application/zip)
2019-11-12 05:11 PST, EWS Watchlist
no flags Details
Patch (332.71 KB, patch)
2019-11-12 08:42 PST, Simon Fraser (smfr)
koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-11-11 22:09:20 PST
Convert CSSPrimitiveValue::UnitType to an enum class, and cleanup
Comment 1 Simon Fraser (smfr) 2019-11-11 22:12:23 PST
Created attachment 383335 [details]
Comment 2 Simon Fraser (smfr) 2019-11-11 22:54:48 PST
I'll get rid of the ugly CSS_FOO values in a second patch.
Comment 3 EWS Watchlist 2019-11-12 05:11:52 PST
Comment on attachment 383335 [details]

Attachment 383335 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13242312

New failing tests:
Comment 4 EWS Watchlist 2019-11-12 05:11:54 PST
Created attachment 383349 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 Simon Fraser (smfr) 2019-11-12 08:42:23 PST
Created attachment 383359 [details]
Comment 6 WebKit Commit Bot 2019-11-12 11:33:14 PST
Comment on attachment 383359 [details]

Rejecting attachment 383359 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 383359, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
k #47 succeeded at 3502 (offset -9 lines).
Hunk #48 succeeded at 3512 (offset -9 lines).
Hunk #49 succeeded at 3538 (offset -9 lines).
Hunk #50 succeeded at 3553 (offset -9 lines).
Hunk #51 succeeded at 3751 (offset -9 lines).
patching file Source/WebCore/css/CSSCrossfadeValue.cpp
patching file Source/WebCore/css/CSSCustomPropertyValue.cpp
patching file Source/WebCore/css/CSSFontFace.cpp
patching file Source/WebCore/css/CSSFontStyleValue.h
patching file Source/WebCore/css/CSSGradientValue.cpp
patching file Source/WebCore/css/CSSImageValue.cpp
patching file Source/WebCore/css/CSSPrimitiveValue.cpp
Hunk #12 succeeded at 601 (offset 5 lines).
Hunk #13 succeeded at 634 (offset 5 lines).
Hunk #14 succeeded at 723 with fuzz 1 (offset 24 lines).
Hunk #15 succeeded at 731 (offset 24 lines).
Hunk #16 succeeded at 783 (offset 24 lines).
Hunk #17 succeeded at 875 (offset 24 lines).
Hunk #18 succeeded at 885 (offset 24 lines).
Hunk #19 succeeded at 903 (offset 24 lines).
Hunk #20 succeeded at 921 (offset 24 lines).
Hunk #21 succeeded at 949 (offset 24 lines).
Hunk #22 succeeded at 1043 (offset 24 lines).
Hunk #23 succeeded at 1094 (offset 24 lines).
Hunk #24 succeeded at 1176 (offset 24 lines).
patching file Source/WebCore/css/CSSPrimitiveValue.h
Hunk #3 FAILED at 237.
Hunk #4 succeeded at 293 (offset 2 lines).
Hunk #5 succeeded at 313 (offset 2 lines).
Hunk #6 succeeded at 342 (offset 2 lines).
Hunk #7 succeeded at 377 (offset 2 lines).
Hunk #8 succeeded at 386 (offset 2 lines).
1 out of 8 hunks FAILED -- saving rejects to file Source/WebCore/css/CSSPrimitiveValue.h.rej
patching file Source/WebCore/css/CSSPrimitiveValueMappings.h
patching file Source/WebCore/css/CSSStyleDeclaration.cpp
patching file Source/WebCore/css/CSSToStyleMap.cpp
patching file Source/WebCore/css/CSSValue.h
patching file Source/WebCore/css/CSSValuePool.cpp
patching file Source/WebCore/css/CSSValuePool.h
patching file Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp
patching file Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h
patching file Source/WebCore/css/DeprecatedCSSOMRGBColor.h
patching file Source/WebCore/css/MediaQueryEvaluator.cpp
patching file Source/WebCore/css/MediaQueryExpression.cpp
patching file Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp
patching file Source/WebCore/css/StyleProperties.cpp
patching file Source/WebCore/css/parser/CSSParserFastPaths.cpp
patching file Source/WebCore/css/parser/CSSParserToken.cpp
patching file Source/WebCore/css/parser/CSSParserToken.h
patching file Source/WebCore/css/parser/CSSPropertyParser.cpp
patching file Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
patching file Source/WebCore/css/parser/MediaQueryParser.cpp
patching file Source/WebCore/css/parser/SizesAttributeParser.cpp
patching file Source/WebCore/css/parser/SizesAttributeParser.h
patching file Source/WebCore/css/typedom/StylePropertyMapReadOnly.cpp
patching file Source/WebCore/dom/StyledElement.cpp
patching file Source/WebCore/dom/StyledElement.h
patching file Source/WebCore/editing/ApplyStyleCommand.cpp
patching file Source/WebCore/editing/EditingStyle.cpp
patching file Source/WebCore/editing/FontAttributeChanges.cpp
patching file Source/WebCore/editing/cocoa/HTMLConverter.mm
patching file Source/WebCore/html/HTMLElement.cpp
patching file Source/WebCore/html/HTMLEmbedElement.cpp
patching file Source/WebCore/html/HTMLHRElement.cpp
patching file Source/WebCore/html/HTMLIFrameElement.cpp
patching file Source/WebCore/html/HTMLInputElement.cpp
patching file Source/WebCore/html/HTMLMeterElement.cpp
patching file Source/WebCore/html/HTMLTableElement.cpp
patching file Source/WebCore/html/ValidationMessage.cpp
patching file Source/WebCore/html/shadow/MediaControlElements.cpp
patching file Source/WebCore/html/shadow/ProgressShadowElement.cpp
patching file Source/WebCore/html/shadow/TextControlInnerElements.cpp
patching file Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp
patching file Source/WebCore/html/track/TextTrackCueGeneric.cpp
patching file Source/WebCore/html/track/VTTCue.cpp
patching file Source/WebCore/html/track/VTTRegion.cpp
patching file Source/WebCore/page/DragController.cpp
patching file Source/WebCore/page/PrintContext.cpp
patching file Source/WebCore/page/animation/CSSPropertyAnimation.cpp
patching file Source/WebCore/rendering/RenderLayer.cpp
Hunk #1 succeeded at 3017 (offset 13 lines).
patching file Source/WebCore/rendering/RenderThemeIOS.mm
patching file Source/WebCore/style/StyleBuilderConverter.h
patching file Source/WebCore/style/StyleBuilderCustom.h
patching file Source/WebCore/svg/SVGLengthValue.cpp
patching file Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
patching file Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm
patching file Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13243124
Comment 7 Simon Fraser (smfr) 2019-11-12 21:00:20 PST
Comment 8 Radar WebKit Bug Importer 2019-11-12 21:01:18 PST