RESOLVED FIXED 204098
Skip matched declarations cache only for length resolution affecting font properties 
https://bugs.webkit.org/show_bug.cgi?id=204098
Summary Skip matched declarations cache only for length resolution affecting font pro...
Antti Koivisto
Reported 2019-11-11 17:22:16 PST
Instead of skipping on any sort of font change.
Attachments
patch (5.82 KB, patch)
2019-11-11 17:26 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-11-11 17:26:31 PST
Created attachment 383325 [details] patch
WebKit Commit Bot
Comment 2 2019-11-12 11:32:34 PST
Comment on attachment 383325 [details] patch Clearing flags on attachment: 383325 Committed r252370: <https://trac.webkit.org/changeset/252370>
WebKit Commit Bot
Comment 3 2019-11-12 11:32:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-11-12 11:34:21 PST
<rdar://problem/57124173>
Simon Fraser (smfr)
Comment 5 2019-11-12 23:10:51 PST
Comment on attachment 383325 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=383325&action=review > Source/WebCore/css/CSSPrimitiveValue.cpp:708 > +bool CSSPrimitiveValue::equalForLengthResolution(const RenderStyle& styleA, const RenderStyle& styleB) Why is this a function on CSSPrimitiveValue? Seems like it could be on RenderStyle.
Antti Koivisto
Comment 6 2019-11-13 10:54:07 PST
> Why is this a function on CSSPrimitiveValue? Seems like it could be on > RenderStyle. I put it next to the length resolution function (CSSPrimitiveValue::computeNonCalcLengthDouble) since these two must stay in sync. They should be moved somewhere else together.
Note You need to log in before you can comment on or make changes to this bug.