Bug 204098 - Skip matched declarations cache only for length resolution affecting font properties
Summary: Skip matched declarations cache only for length resolution affecting font pro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-11 17:22 PST by Antti Koivisto
Modified: 2019-11-13 10:54 PST (History)
11 users (show)

See Also:

Attachments
patch (5.82 KB, patch)
2019-11-11 17:26 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-11-11 17:22:16 PST 
Instead of skipping on any sort of font change.
Comment 1 Antti Koivisto 2019-11-11 17:26:31 PST 
Created attachment 383325 [details]
patch
Comment 2 WebKit Commit Bot 2019-11-12 11:32:34 PST 
Comment on attachment 383325 [details]
patch

Clearing flags on attachment: 383325

Committed r252370: <https://trac.webkit.org/changeset/252370>
Comment 3 WebKit Commit Bot 2019-11-12 11:32:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-11-12 11:34:21 PST 
<rdar://problem/57124173>
Comment 5 Simon Fraser (smfr) 2019-11-12 23:10:51 PST 
Comment on attachment 383325 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383325&action=review

> Source/WebCore/css/CSSPrimitiveValue.cpp:708
> +bool CSSPrimitiveValue::equalForLengthResolution(const RenderStyle& styleA, const RenderStyle& styleB)

Why is this a function on CSSPrimitiveValue? Seems like it could be on RenderStyle.
Comment 6 Antti Koivisto 2019-11-13 10:54:07 PST 
> Why is this a function on CSSPrimitiveValue? Seems like it could be on
> RenderStyle.

I put it next to the length resolution function (CSSPrimitiveValue::computeNonCalcLengthDouble) since these two must stay in sync.

They should be moved somewhere else together.