Bug 204097 – Web Inspector: Sources: create/update local override drop zone shown in image collection view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page with lots of images (e.g. <https://apple.com>)
2. select the Images folder in the Sources Tab
3. drag an image over the collection view
 => "Create Local Override" drop zone shown

[Devin Rousso]

Created attachment 383321 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 383321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383321&action=review

> Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js:107
> +    get contentViewConstructorOptions()
> +    {
> +        let contentViewConstructorOptions = super.contentViewConstructorOptions;
> +        if (this.representedObject.resourceType === WI.Resource.Type.Image)
> +            contentViewConstructorOptions.disableDropZone = true;
> +        return contentViewConstructorOptions;
> +    }

Why not make collection content views always have `disableDropZone = true`. This only does it for a resource type of Image?

[EWS Watchlist]

Comment on attachment 383321 [details]
Patch

Attachment 383321 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13241720

New failing tests:
imported/blink/fast/events/panScroll-crash.html

[EWS Watchlist]

Created attachment 383340 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Devin Rousso]

Comment on attachment 383321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383321&action=review

>> Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js:107
>> +    }
> 
> Why not make collection content views always have `disableDropZone = true`. This only does it for a resource type of Image?

I'd rather not pass it to constructors that aren't expecting it.

[WebKit Commit Bot]

Comment on attachment 383321 [details]
Patch

Clearing flags on attachment: 383321

Committed r252378: <https://trac.webkit.org/changeset/252378>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57135784>