Bug 204077 - ASSERT at PlatformCALayerCocoa::avPlayerLayer(): [platformLayer() sublayers].count == 1
Summary: ASSERT at PlatformCALayerCocoa::avPlayerLayer(): [platformLayer() sublayers]....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-11 11:04 PST by Jer Noble
Modified: 2019-11-11 17:05 PST (History)
8 users (show)

See Also:

Attachments
Patch (16.99 KB, patch)
2019-11-11 11:07 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (16.48 KB, patch)
2019-11-11 13:24 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2019-11-11 11:04:01 PST 
ASSERT at PlatformCALayerCocoa::avPlayerLayer(): [platformLayer() sublayers].count == 1
Comment 1 Jer Noble 2019-11-11 11:04:27 PST 
<rdar://problem/56640423>
Comment 2 Jer Noble 2019-11-11 11:07:23 PST 
Created attachment 383285 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-11-11 11:40:47 PST 
Comment on attachment 383285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383285&action=review

> Source/WebCore/platform/graphics/ca/cocoa/WebVideoContainerLayer.mm:53
> +        // Pre-apply the transform added in the WebProcess to fix <rdar://problem/18316542> to the position.

Comment doesn't parse.
Comment 4 Jer Noble 2019-11-11 13:12:04 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 383285 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383285&action=review
> 
> > Source/WebCore/platform/graphics/ca/cocoa/WebVideoContainerLayer.mm:53
> > +        // Pre-apply the transform added in the WebProcess to fix <rdar://problem/18316542> to the position.
> 
> Comment doesn't parse.

I didn't write it, I just moved it from one file to another.
Comment 5 Jer Noble 2019-11-11 13:24:59 PST 
Created attachment 383291 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-11-11 17:05:04 PST 
Comment on attachment 383291 [details]
Patch for landing

Clearing flags on attachment: 383291

Committed r252346: <https://trac.webkit.org/changeset/252346>
Comment 7 WebKit Commit Bot 2019-11-11 17:05:06 PST 
All reviewed patches have been landed.  Closing bug.