Bug 204071 - [EWS] Use named arguments in factories.py
Summary: [EWS] Use named arguments in factories.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-11 08:38 PST by Aakash Jain
Modified: 2019-11-11 16:50 PST (History)
6 users (show)

See Also:

Attachments
Patch (9.76 KB, patch)
2019-11-11 08:42 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-11 08:38:39 PST 
We should use named arguments in factories.py. It's much more clear, and less error-prone.
Comment 1 Aakash Jain 2019-11-11 08:42:22 PST 
Created attachment 383272 [details]
Patch
Comment 2 Jonathan Bedard 2019-11-11 08:44:19 PST 
Comment on attachment 383272 [details]
Patch

I think I actually complained about this in a patch a few months ago...
Comment 3 WebKit Commit Bot 2019-11-11 09:49:24 PST 
Comment on attachment 383272 [details]
Patch

Clearing flags on attachment: 383272

Committed r252329: <https://trac.webkit.org/changeset/252329>
Comment 4 WebKit Commit Bot 2019-11-11 09:49:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-11-11 16:50:04 PST 
<rdar://problem/57099069>