Bug 204069 - OverConstrainedError is missing 'name' property
Summary: OverConstrainedError is missing 'name' property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-11 07:40 PST by Eric Carlson
Modified: 2019-11-19 08:52 PST (History)
13 users (show)

See Also:


Attachments
Patch (7.93 KB, patch)
2019-11-18 11:05 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch (9.42 KB, patch)
2019-11-19 05:40 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-11-11 07:40:51 PST
OverconstrainedError.name returns "Error", but spec says:

    The initial value of the name property of the prototype for the OverconstrainedError constructor is "OverconstrainedError".

https://w3c.github.io/mediacapture-main/#overconstrainederror-prototype-name
Comment 1 Eric Carlson 2019-11-18 11:05:07 PST
Created attachment 383763 [details]
Patch
Comment 2 youenn fablet 2019-11-18 17:02:18 PST
Comment on attachment 383763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383763&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, existing test and results updated.

There is one failing test on Mac that probably needs to get updated.

> LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/GUM-impossible-constraint.https-expected.txt:8
> +FAIL Tests that setting an impossible constraint in getUserMedia fails assert_equals: The name of the not satisfied error is given in error.constraint expected "width" but got ""

We should look at these tests, maybe we should update them since we are not exposing the constraint if device info is not granted.
Comment 3 Eric Carlson 2019-11-19 05:40:06 PST
Created attachment 383861 [details]
Patch
Comment 4 WebKit Commit Bot 2019-11-19 08:51:03 PST
Comment on attachment 383861 [details]
Patch

Clearing flags on attachment: 383861

Committed r252632: <https://trac.webkit.org/changeset/252632>
Comment 5 WebKit Commit Bot 2019-11-19 08:51:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-19 08:52:22 PST
<rdar://problem/57323357>