Bug 204063 - [GTK] Add 'test262-test' step to GTK and WPE build bots
Summary: [GTK] Add 'test262-test' step to GTK and WPE build bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-11 02:00 PST by Diego Pino
Modified: 2019-11-13 06:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.92 KB, patch)
2019-11-11 02:00 PST, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (7.97 KB, patch)
2019-11-11 07:52 PST, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (8.34 KB, patch)
2019-11-11 09:43 PST, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (8.39 KB, patch)
2019-11-12 06:15 PST, Diego Pino 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2019-11-11 02:00:13 PST 
[GTK] Add 'test262-test' to GTK and JSCOnly build bots
Comment 1 Diego Pino 2019-11-11 02:00:51 PST 
Created attachment 383256 [details]
Patch
Comment 2 Diego Pino 2019-11-11 07:52:52 PST 
Created attachment 383269 [details]
Patch
Comment 3 Carlos Alberto Lopez Perez 2019-11-11 08:36:43 PST 
Comment on attachment 383269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383269&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:111
>          if platform == "gtk":
>              self.addStep(RunGtkAPITests())
>              self.addStep(RunWebDriverTests())
> +            self.addStep(RunTest262Tests())
>          if platform == "wpe":
>              self.addStep(RunWPEAPITests())

We likely want to run it also on the WPE bots.

> Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:149
> +        self.addStep(RunTest262Tests(timeout=60 * 60))

Does this script support running remotely? If not then we can't run it on the JSCOnly buildbots that run remote JSC tests
Comment 4 Diego Pino 2019-11-11 09:43:26 PST 
Created attachment 383277 [details]
Patch
Comment 5 Carlos Alberto Lopez Perez 2019-11-11 09:54:50 PST 
Comment on attachment 383277 [details]
Patch

r=me.
Comment 6 WebKit Commit Bot 2019-11-12 06:11:35 PST 
Comment on attachment 383277 [details]
Patch

Rejecting attachment 383277 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 383277, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/13242490
Comment 7 Diego Pino 2019-11-12 06:15:00 PST 
Created attachment 383350 [details]
Patch
Comment 8 WebKit Commit Bot 2019-11-12 07:07:29 PST 
Comment on attachment 383350 [details]
Patch

Clearing flags on attachment: 383350

Committed r252362: <https://trac.webkit.org/changeset/252362>
Comment 9 WebKit Commit Bot 2019-11-12 07:07:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-11-12 07:08:17 PST 
<rdar://problem/57115334>