Bug 204055 - [LFC][IFC] Move Line::Run's line layout specific logic to InlineItemRun
Summary: [LFC][IFC] Move Line::Run's line layout specific logic to InlineItemRun
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-09 19:03 PST by zalan
Modified: 2019-11-10 20:10 PST (History)
6 users (show)

See Also:

Attachments
Patch (43.96 KB, patch)
2019-11-09 19:55 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-09 19:03:34 PST 
and have only the interface/merging logic in Line::Run
Comment 1 Radar WebKit Bug Importer 2019-11-09 19:03:53 PST 
<rdar://problem/57053232>
Comment 2 zalan 2019-11-09 19:55:49 PST 
Created attachment 383234 [details]
Patch
Comment 3 Antti Koivisto 2019-11-10 07:51:50 PST 
Comment on attachment 383234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383234&action=review

> Source/WebCore/layout/inlineformatting/InlineLine.cpp:68
> +    Display::Rect m_logicalRect;

This can probably be const too.
Comment 4 zalan 2019-11-10 19:25:45 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 383234 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383234&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLine.cpp:68
> > +    Display::Rect m_logicalRect;
> 
> This can probably be const too.

Currently setCollapsesToZeroAdvanceWidth() mutates it but I might be able to change that.
Comment 5 WebKit Commit Bot 2019-11-10 20:10:06 PST 
Comment on attachment 383234 [details]
Patch

Clearing flags on attachment: 383234

Committed r252316: <https://trac.webkit.org/changeset/252316>
Comment 6 WebKit Commit Bot 2019-11-10 20:10:08 PST 
All reviewed patches have been landed.  Closing bug.