RESOLVED FIXED 204055
[LFC][IFC] Move Line::Run's line layout specific logic to InlineItemRun 
https://bugs.webkit.org/show_bug.cgi?id=204055
Summary [LFC][IFC] Move Line::Run's line layout specific logic to InlineItemRun
zalan
Reported 2019-11-09 19:03:34 PST
and have only the interface/merging logic in Line::Run
Attachments
Patch (43.96 KB, patch)
2019-11-09 19:55 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-09 19:03:53 PST
<rdar://problem/57053232>
zalan
Comment 2 2019-11-09 19:55:49 PST
Created attachment 383234 [details] Patch
Antti Koivisto
Comment 3 2019-11-10 07:51:50 PST
Comment on attachment 383234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383234&action=review > Source/WebCore/layout/inlineformatting/InlineLine.cpp:68 > + Display::Rect m_logicalRect; This can probably be const too.
zalan
Comment 4 2019-11-10 19:25:45 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 383234 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383234&action=review > > > Source/WebCore/layout/inlineformatting/InlineLine.cpp:68 > > + Display::Rect m_logicalRect; > > This can probably be const too. Currently setCollapsesToZeroAdvanceWidth() mutates it but I might be able to change that.
WebKit Commit Bot
Comment 5 2019-11-10 20:10:06 PST
Comment on attachment 383234 [details] Patch Clearing flags on attachment: 383234 Committed r252316: <https://trac.webkit.org/changeset/252316>
WebKit Commit Bot
Comment 6 2019-11-10 20:10:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.