Bug 204051 - [WebAssembly] Improve bytecode dumping
Summary: [WebAssembly] Improve bytecode dumping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-09 11:27 PST by Tadeu Zagallo
Modified: 2019-11-11 17:01 PST (History)
7 users (show)

See Also:

Attachments
Patch (19.67 KB, patch)
2019-11-09 11:30 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (20.11 KB, patch)
2019-11-09 14:19 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (20.14 KB, patch)
2019-11-09 14:35 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-11-09 11:27:26 PST 
...
Comment 1 Tadeu Zagallo 2019-11-09 11:30:20 PST 
Created attachment 383224 [details]
Patch
Comment 2 Keith Miller 2019-11-09 12:00:30 PST 
Comment on attachment 383224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383224&action=review

r=me

> Source/JavaScriptCore/ChangeLog:17
> +        <?>.wasm-function[26]: 6 instructions (0 16-bit instructions, 0 32-bit instructions); 14 bytes; 1 parameter(s); 18 local(s); 22 callee register(s)

It’d be cool if we could dump the signature of the function here.
Comment 3 Tadeu Zagallo 2019-11-09 14:07:02 PST 
Comment on attachment 383224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383224&action=review

Thanks for the review

>> Source/JavaScriptCore/ChangeLog:17
>> +        <?>.wasm-function[26]: 6 instructions (0 16-bit instructions, 0 32-bit instructions); 14 bytes; 1 parameter(s); 18 local(s); 22 callee register(s)
> 
> It’d be cool if we could dump the signature of the function here.

Nice, I'll add it.
Comment 4 Tadeu Zagallo 2019-11-09 14:19:24 PST 
Created attachment 383226 [details]
Patch for landing
Comment 5 Tadeu Zagallo 2019-11-09 14:34:36 PST 
Oops, I forgot to include WasmSignatureInlines
Comment 6 Tadeu Zagallo 2019-11-09 14:35:38 PST 
Created attachment 383227 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-11-09 15:34:29 PST 
The commit-queue encountered the following flaky tests while processing attachment 383227 [details]:

inspector/model/remote-object-weak-collection.html bug 204016 (authors: drousso@apple.com and joepeck@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2019-11-09 15:35:18 PST 
Comment on attachment 383227 [details]
Patch for landing

Clearing flags on attachment: 383227

Committed r252310: <https://trac.webkit.org/changeset/252310>
Comment 9 WebKit Commit Bot 2019-11-09 15:35:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-11-11 17:01:47 PST 
<rdar://problem/57099444>