Bug 204051 – [WebAssembly] Improve bytecode dumping

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Tadeu Zagallo]

...

[Tadeu Zagallo]

Created attachment 383224 [details]
Patch

[Keith Miller]

Comment on attachment 383224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383224&action=review

r=me

> Source/JavaScriptCore/ChangeLog:17
> +        <?>.wasm-function[26]: 6 instructions (0 16-bit instructions, 0 32-bit instructions); 14 bytes; 1 parameter(s); 18 local(s); 22 callee register(s)

It’d be cool if we could dump the signature of the function here.

[Tadeu Zagallo]

Comment on attachment 383224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383224&action=review

Thanks for the review

>> Source/JavaScriptCore/ChangeLog:17
>> +        <?>.wasm-function[26]: 6 instructions (0 16-bit instructions, 0 32-bit instructions); 14 bytes; 1 parameter(s); 18 local(s); 22 callee register(s)
> 
> It’d be cool if we could dump the signature of the function here.

Nice, I'll add it.

[Tadeu Zagallo]

Created attachment 383226 [details]
Patch for landing

[Tadeu Zagallo]

Oops, I forgot to include WasmSignatureInlines

[Tadeu Zagallo]

Created attachment 383227 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 383227 [details]:

inspector/model/remote-object-weak-collection.html bug 204016 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 383227 [details]
Patch for landing

Clearing flags on attachment: 383227

Committed r252310: <https://trac.webkit.org/changeset/252310>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57099444>