Bug 204047 – Unskip some fetch tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Rob Buis]

Two fetch tests are reported as timing out but do not time out (anymore):

 # These fetch tests time out
-imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-no-load-event.https.html [ Skip ]
 imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination.https.html [ Skip ]
-imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker.html [ Skip ]

[Rob Buis]

Created attachment 383213 [details]
Patch

[Rob Buis]

Created attachment 383219 [details]
Patch

[Rob Buis]

Created attachment 383220 [details]
Patch

[Rob Buis]

Created attachment 383221 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 383221 [details]
Patch

Clearing flags on attachment: 383221

Committed r252363: <https://trac.webkit.org/changeset/252363>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57115612>

[Truitt Savell]

Both of these unskipped tests are flakey failures.

This one is flakey on iOS
imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-no-load-event.https.html 

This one is flakey on Mac and iOS
imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker.html

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fcontent-encoding%2Fbad-gzip-body.any.worker.html&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fapi%2Frequest%2Fdestination%2Ffetch-destination-no-load-event.https.html

[Rob Buis]

(In reply to Truitt Savell from comment #8)
> Both of these unskipped tests are flakey failures.
> 
> This one is flakey on iOS
> imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-
> destination-no-load-event.https.html 
> 
> This one is flakey on Mac and iOS
> imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.
> worker.html
> 
> History:
> https://results.webkit.org/?suite=layout-tests&suite=layout-
> tests&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fcontent-
> encoding%2Fbad-gzip-body.any.worker.html&test=imported%2Fw3c%2Fweb-platform-
> tests%2Ffetch%2Fapi%2Frequest%2Fdestination%2Ffetch-destination-no-load-
> event.https.html

Sounds like these tests changed from being timeouts to flaky tests at some point. I guess we have the choice of reverting the patch or marking as flaky. WDYT?

[Truitt Savell]

I believe having tests is better than not having tests. I think these should be marked as failures and a new bug filed for the failures.

[Rob Buis]

(In reply to Truitt Savell from comment #10)
> I believe having tests is better than not having tests. I think these should
> be marked as failures and a new bug filed for the failures.

Sounds good. I am done for the day here in Europe, but if you want I can look into it over the weekend.

[Truitt Savell]

Made new bugs and marked the tests as flakey while you are investigating

https://bugs.webkit.org/show_bug.cgi?id=204756
https://bugs.webkit.org/show_bug.cgi?id=204757