NEW204038
[SVG2] Fix the IDL and the class inheritance of SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=204038
Summary [SVG2] Fix the IDL and the class inheritance of SVGGraphicsElement
Said Abou-Hallawa
Reported 2019-11-08 18:04:11 PST
r152404 removed the IDL of SVGTransformable and SVGLocatable but it left the C++ classes and some of their methods exposed in SVGGraphicsElement.idl. The IDL of SVGGraphicsElement is defined here: https://www.w3.org/TR/SVG/types.html#InterfaceSVGGraphicsElement. So we need to remove the following attributes and method from SVGGraphicsElement.idl: readonly attribute SVGElement nearestViewportElement; readonly attribute SVGElement farthestViewportElement; [MayThrowException, NewObject] SVGMatrix getTransformToElement(optional SVGElement? element = null); Also we need to remove the inheritance relationship from SVGGraphicsElement to SVGTransformable. In fact all the virtual methods of SVGTransformable and SVGLocatable should be moved to SVGGraphicsElement. The static methods of SVGTransformable are still needed for parsing the SVGTransformValue and SVGTransformType.
Attachments
Patch (125.92 KB, patch)
2019-11-08 18:27 PST, Said Abou-Hallawa
no flags
Patch (138.41 KB, patch)
2019-11-10 22:44 PST, Said Abou-Hallawa
no flags
Patch (127.49 KB, patch)
2019-11-11 13:18 PST, Said Abou-Hallawa
no flags
Archive of layout-test-results from ews210 for win-future (14.44 MB, application/zip)
2019-11-11 21:50 PST, EWS Watchlist
no flags
Patch (89.83 KB, patch)
2019-11-21 11:19 PST, Said Abou-Hallawa
no flags
Archive of layout-test-results from ews210 for win-future (14.18 MB, application/zip)
2019-11-22 02:45 PST, EWS Watchlist
no flags
Patch (92.81 KB, patch)
2019-11-22 09:41 PST, Said Abou-Hallawa
sabouhallawa: review?
Said Abou-Hallawa
Comment 1 2019-11-08 18:27:11 PST
Said Abou-Hallawa
Comment 2 2019-11-10 22:44:02 PST
Said Abou-Hallawa
Comment 3 2019-11-11 13:18:44 PST
EWS Watchlist
Comment 4 2019-11-11 21:50:01 PST
Comment on attachment 383290 [details] Patch Attachment 383290 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13241573 New failing tests: svg/W3C-SVG-1.1/types-basicDOM-01-b.svg
EWS Watchlist
Comment 5 2019-11-11 21:50:04 PST
Created attachment 383333 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Said Abou-Hallawa
Comment 6 2019-11-21 11:19:38 PST
EWS Watchlist
Comment 7 2019-11-22 02:45:37 PST
Comment on attachment 384075 [details] Patch Attachment 384075 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13272591 New failing tests: svg/W3C-SVG-1.1/types-basicDOM-01-b.svg
EWS Watchlist
Comment 8 2019-11-22 02:45:39 PST
Created attachment 384139 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Said Abou-Hallawa
Comment 9 2019-11-22 09:41:34 PST
Radar WebKit Bug Importer
Comment 10 2024-02-08 15:13:03 PST
Karl Dubost
Comment 11 2024-12-16 23:55:13 PST
Still the case as of today http://wpt.live/svg/historical.html
Note You need to log in before you can comment on or make changes to this bug.