RESOLVED FIXED 204037
Long-pressing support.apple.com categories shows a PNG instead of the web page preview, tapping loads image asset only instead of web page
https://bugs.webkit.org/show_bug.cgi?id=204037
Summary Long-pressing support.apple.com categories shows a PNG instead of the web pag...
Dean Jackson
Reported 2019-11-08 17:43:00 PST
Clicky Orbing support.apple.com categories shows a PNG instead of the web page preview, tapping loads image asset only instead of web page
Attachments
Patch (28.21 KB, patch)
2019-11-08 17:51 PST, Dean Jackson
simon.fraser: review+
Dean Jackson
Comment 1 2019-11-08 17:51:51 PST
Dean Jackson
Comment 2 2019-11-08 17:52:12 PST
Simon Fraser (smfr)
Comment 3 2019-11-09 11:37:33 PST
Comment on attachment 383189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383189&action=review > Source/WebKit/ChangeLog:10 > + Sometime recently, Safari started using our ContextMenu API rather than the old SPI. At that > + point they accidentally began providing a PreviewViewController that displayed the image Maybe reword this. > Source/WebKit/ChangeLog:15 > + This could be fixed in Safari, but I noticed that we actually tell the delegate that the > + type of the activated element is an image, which is why they treat it as such. It's not > + clear that because the image also has a link attached, a client should defer to the link. Are we not able to tell the client "link and image"?
Dean Jackson
Comment 4 2019-11-09 12:16:13 PST
Dean Jackson
Comment 5 2019-11-09 13:04:40 PST
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 383189 [details] > > Are we not able to tell the client "link and image"? We do. We don't give them a type, just information on whether there is a link and whether there is an image. The client decides what to do.
Aakash Jain
Comment 6 2019-11-10 05:11:54 PST
(In reply to Dean Jackson from comment #4) > Committed r252309: <https://trac.webkit.org/changeset/252309> The newly added API test TestWebKitAPI._WKActivatedElementInfo.InfoForLinkAroundImage is failing consistently on iOS. EWS status-bubble for api-ios was also red and indicated this failure. Tracked in Bug 204058.
Note You need to log in before you can comment on or make changes to this bug.