Bug 204032 – UTC offset for Samoa is miscalculated when !HAVE(TIMEGM)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Ross Kirsling]

UTC offset for Samoa is miscalculated when !HAVE(TIMEGM)

[Ross Kirsling]

Created attachment 383181 [details]
Patch

[Ross Kirsling]

Not sure if this is possible to test, but repro scenario on Mac is the following:
1. Set system time zone to that of Apia, Samoa.
2. Notice that `new Date().getTimezoneOffset() / -60` is 13 or 14.
3. Change #if HAVE(TIMEGM) and #if HAVE(TM_GMTOFF) to #if 0 in DateMath.cpp.
4. Notice that `new Date().getTimezoneOffset() / -60` is now -10 or -11.

[Ross Kirsling]

Also, please feel free to counter-suggest a more sustainable solution. :P

[Yusuke Suzuki]

Comment on attachment 383181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383181&action=review

> Source/WTF/ChangeLog:9
> +        but Samoa changed from UTC-11 to UTC+13 at the beginning of 2012.

Let's write a test by setting `TZ=Pacific/Samoa`!
You can extend run-jsc-stress-tests, maybe, extending runComplexTest, and pass environment variables as additionalEnv. And specify it from `complex.yaml` in JSTests.

[Ross Kirsling]

(In reply to Yusuke Suzuki from comment #4)
> Comment on attachment 383181 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383181&action=review
> 
> > Source/WTF/ChangeLog:9
> > +        but Samoa changed from UTC-11 to UTC+13 at the beginning of 2012.
> 
> Let's write a test by setting `TZ=Pacific/Samoa`!
> You can extend run-jsc-stress-tests, maybe, extending runComplexTest, and
> pass environment variables as additionalEnv. And specify it from
> `complex.yaml` in JSTests.

Can do.

By the way, it turns out Pacific/Samoa is for American Samoa, which is still UTC-11; I guess the one we need here is Pacific/Apia. Talk about confusing!
(https://en.wikipedia.org/wiki/Time_in_Samoa)

[Ross Kirsling]

Created attachment 383307 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 383307 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 383307 [details]
Patch

Clearing flags on attachment: 383307

Committed r252345: <https://trac.webkit.org/changeset/252345>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57099380>