Bug 204013 – Captcha images render as blank white space

• Status: RESOLVED
• Resolution: FIXED
• Component: Compositing

[Simon Fraser (smfr)]

reCaptcha in an iframe sometimes goes blank when the user clicks on one of the squares.

[Simon Fraser (smfr)]

rdar://problem/50095458

[Simon Fraser (smfr)]

I think what's happening here is that the visibility transition on the parent frame is adding a RenderLayer to the paint-order tree that has a "HasDescendantNeedingRequirementsTraversal" bit, but that bit doesn't propagate to the root so we fail to traverse the iframe, and thus never parent the iframe's layers.

[Simon Fraser (smfr)]

Created attachment 383195 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 383311 [details]
Patch

[Dean Jackson]

Comment on attachment 383311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383311&action=review

> LayoutTests/ChangeLog:31
> [phone]  Simon Fraser  <[e-mail]>
> +
> +        Captcha images render as blank white space
> +        https://bugs.webkit.org/show_bug.cgi?id=204013
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * compositing/visibility/resources/become-composited.html: Added.
> +        * compositing/visibility/resources/frame-with-visibility-change.html: Added.
> +        * compositing/visibility/visibility-change-in-subframe-expected.txt: Added.
> +        * compositing/visibility/visibility-change-in-subframe.html: Added.

oops.

[Simon Fraser (smfr)]

Created attachment 383312 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/252353/webkit

[Uri Klar]

What is the status of this issue? I can reproduce this in v13.0.3