Bug 204013 - Captcha images render as blank white space
Summary: Captcha images render as blank white space
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Compositing (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-08 11:29 PST by Simon Fraser (smfr)
Modified: 2020-01-24 01:53 PST (History)
12 users (show)

See Also:

Attachments
Patch (19.33 KB, patch)
2019-11-08 19:05 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (30.21 KB, patch)
2019-11-11 16:13 PST, Simon Fraser (smfr) 		zalan: review+
Details | Formatted Diff | Diff
Patch (29.70 KB, patch)
2019-11-11 16:18 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-11-08 11:29:06 PST 
reCaptcha in an iframe sometimes goes blank when the user clicks on one of the squares.
Comment 1 Simon Fraser (smfr) 2019-11-08 11:29:18 PST 
rdar://problem/50095458
Comment 2 Simon Fraser (smfr) 2019-11-08 14:16:44 PST 
I think what's happening here is that the visibility transition on the parent frame is adding a RenderLayer to the paint-order tree that has a "HasDescendantNeedingRequirementsTraversal" bit, but that bit doesn't propagate to the root so we fail to traverse the iframe, and thus never parent the iframe's layers.
Comment 3 Simon Fraser (smfr) 2019-11-08 19:05:01 PST 
Created attachment 383195 [details]
Patch
Comment 4 Simon Fraser (smfr) 2019-11-11 16:13:33 PST 
Created attachment 383311 [details]
Patch
Comment 5 Dean Jackson 2019-11-11 16:15:38 PST 
Comment on attachment 383311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383311&action=review

> LayoutTests/ChangeLog:31
> +2019-11-08  Simon Fraser  <simon.fraser@apple.com>
> +
> +        Captcha images render as blank white space
> +        https://bugs.webkit.org/show_bug.cgi?id=204013
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * compositing/visibility/resources/become-composited.html: Added.
> +        * compositing/visibility/resources/frame-with-visibility-change.html: Added.
> +        * compositing/visibility/visibility-change-in-subframe-expected.txt: Added.
> +        * compositing/visibility/visibility-change-in-subframe.html: Added.

oops.
Comment 6 Simon Fraser (smfr) 2019-11-11 16:18:26 PST 
Created attachment 383312 [details]
Patch
Comment 7 Simon Fraser (smfr) 2019-11-11 18:00:03 PST 
https://trac.webkit.org/changeset/252353/webkit
Comment 8 Uri Klar 2019-12-08 04:28:13 PST 
What is the status of this issue? I can reproduce this in v13.0.3