Bug 204009 - [Web Animations] Optimize animation resolution to not re-compute whether effects only contain accelerated animation properties
Summary: [Web Animations] Optimize animation resolution to not re-compute whether effe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-08 09:58 PST by Antoine Quint
Modified: 2019-11-11 16:59 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.23 KB, patch)
2019-11-08 13:04 PST, Antoine Quint
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-11-08 09:58:20 PST
When resolving animations we re-compute whether all animated properties are accelerated to return the `shouldRecompositeLayer` flag in TreeResolver::createAnimatedElementUpdate. We should be able to expose such a property when keyframes on a KeyframeEffect change and then also store it on KeyframeEffectStack and compute that value when the stack is changed.
Comment 1 Antoine Quint 2019-11-08 10:22:24 PST
Retitling because it will likely be enough to do it on just KeyframeEffect since we have to iterate through all the effects of a stack when resolving anyway.
Comment 2 Antoine Quint 2019-11-08 13:02:10 PST
As it turns out KeyframeEffect already caches this information, we just need to use it!
Comment 3 Antoine Quint 2019-11-08 13:04:08 PST
Created attachment 383154 [details]
Patch
Comment 4 Dean Jackson 2019-11-08 13:18:29 PST
Comment on attachment 383154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383154&action=review

> Source/WebCore/ChangeLog:9
> +        of iterating over an effec'ts animated properties during resolution to get at the same information. 

typo
Comment 5 Antoine Quint 2019-11-09 03:05:30 PST
Committed r252307: <https://trac.webkit.org/changeset/252307>
Comment 6 Radar WebKit Bug Importer 2019-11-11 16:59:04 PST
<rdar://problem/57099367>