Bug 204006 – Add WebKit Legacy SPI to retrieve editable elements in rect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Daniel Bates]

Add WebKit Legacy SPI to retrieve editable elements in rect.

[Daniel Bates]

<rdar://problem/57024093>

[Daniel Bates]

Created attachment 383142 [details]
Patch

[Wenson Hsieh]

Comment on attachment 383142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383142&action=review

> Source/WebCore/page/Page.cpp:940
> +            auto node = nodesToSearch.takeFirst();

Nit - auto*

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6696
> +    auto contexts = m_page->editableElementsInRect(searchRect).map([this] (const auto& element) {

Nit - I think we prefer just auto& over const auto&

[Daniel Bates]

Comment on attachment 383142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383142&action=review

Thanks for the review!

>> Source/WebCore/page/Page.cpp:940
>> +            auto node = nodesToSearch.takeFirst();
> 
> Nit - auto*

Ok

>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6696
>> +    auto contexts = m_page->editableElementsInRect(searchRect).map([this] (const auto& element) {
> 
> Nit - I think we prefer just auto& over const auto&

The issue with this is that the compiler will not enforce the const-ness. I cannot envision a case where this code should ever mutate element right now and I am annotating the ref so the compiler can enforce this.

[Daniel Bates]

Comment on attachment 383142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383142&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6695
>      Vector<WebCore::ElementContext> textInputContexts;

This is unused.

[Daniel Bates]

Comment on attachment 383142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383142&action=review

>>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6696
>>> +    auto contexts = m_page->editableElementsInRect(searchRect).map([this] (const auto& element) {
>> 
>> Nit - I think we prefer just auto& over const auto&
> 
> The issue with this is that the compiler will not enforce the const-ness. I cannot envision a case where this code should ever mutate element right now and I am annotating the ref so the compiler can enforce this.

this => &

[Daniel Bates]

Comment on attachment 383142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383142&action=review

> Source/WebCore/page/Page.cpp:944
> +            if (!is<Element>(*node) || !isEditableTextInputElement(downcast<Element>(*node))) {

is<Element>(*node) => is<Element>(node)

[Daniel Bates]

Comment on attachment 383142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383142&action=review

> Source/WebCore/page/Page.cpp:918
> +static bool isEditableTextInputElement(Element& element)

Element& => const Element&

> Source/WebCore/page/Page.cpp:925
> +

Will remove this empty line.

[Daniel Bates]

Created attachment 383153 [details]
To Land

[Daniel Bates]

Committed r252254: <https://trac.webkit.org/changeset/252254>