Bug 203999 - [macOS] Add logging and telemetry to mach lookup rules
Summary: [macOS] Add logging and telemetry to mach lookup rules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-08 08:06 PST by Per Arne Vollan
Modified: 2019-12-04 15:10 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.23 KB, patch)
2019-11-08 08:15 PST, Per Arne Vollan
bfulgham: review+
pvollan: commit-queue?
Details | Formatted Diff | Diff
Patch (3.29 KB, patch)
2019-11-08 11:38 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-11-08 08:06:39 PST
Add logging and telemetry to help determine if mach lookup can be denied in the WebContent process.
Comment 1 Radar WebKit Bug Importer 2019-11-08 08:07:16 PST
<rdar://problem/57021686>
Comment 2 Per Arne Vollan 2019-11-08 08:15:57 PST
Created attachment 383127 [details]
Patch
Comment 3 Brent Fulgham 2019-11-08 11:02:37 PST
Comment on attachment 383127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383127&action=review

r=me

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:601
> +)

These look fine, but we seem to be hitting test failures (which seems crazy to me). Can you double-check we don't have a syntax error in the sandbox?
Comment 4 Per Arne Vollan 2019-11-08 11:18:04 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 383127 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383127&action=review
> 
> r=me
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:601
> > +)
> 
> These look fine, but we seem to be hitting test failures (which seems crazy
> to me). Can you double-check we don't have a syntax error in the sandbox?

Yes, investigating now :)

Thanks for reviewing!
Comment 5 Per Arne Vollan 2019-11-08 11:38:11 PST
Created attachment 383148 [details]
Patch
Comment 6 WebKit Commit Bot 2019-11-08 13:35:18 PST
Comment on attachment 383148 [details]
Patch

Clearing flags on attachment: 383148

Committed r252261: <https://trac.webkit.org/changeset/252261>