NEW 203997
Layout Test jquery/offset.html is flaky 
https://bugs.webkit.org/show_bug.cgi?id=203997
Summary Layout Test jquery/offset.html is flaky
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-08 07:36:45 PST
<rdar://problem/57021074>
Ryosuke Niwa
Comment 2 2019-11-08 09:43:40 PST
This is probably hitting the assertion that needsLayout() is false in FrameView::paintContents. There is on guarantee of this right now because updating the layout can always ran random post layout task. e.g. https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r252198%20(11699)/jquery/offset-crash-log.txt Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x00000001090f7ed0 WTFCrash + 16 (Assertions.cpp:305) 1 com.apple.WebCore 0x000000011a743b0b WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebCore 0x000000011d74c381 WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy) + 721 (FrameView.cpp:4181) 3 com.apple.WebKitLegacy 0x000000011079911c -[WebFrame(WebInternal) _drawRect:contentsOnly:] + 1340 (WebFrame.mm:662) 4 com.apple.WebKitLegacy 0x00000001107be58d -[WebHTMLView drawSingleRect:] + 813 (WebHTMLView.mm:3893) 5 com.apple.WebKitLegacy 0x00000001107beccb -[WebHTMLView drawRect:] + 635 (WebHTMLView.mm:3964) 6 com.apple.AppKit 0x00007fff3a2cbf29 _NSViewDrawRect + 83 7 com.apple.AppKit 0x00007fff39b6473c -[NSView _drawRect:clip:] + 1819 8 com.apple.AppKit 0x00007fff39bacb52 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 1735 9 com.apple.WebKitLegacy 0x00000001107b13cf -[WebHTMLView(WebPrivate) _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 383 (WebHTMLView.mm:1657) 10 com.apple.AppKit 0x00007fff39d4b61c -[NSView _recursiveDisplaySelfAndDescendantsInRect:] + 61 11 com.apple.AppKit 0x00007fff39d3a894 -[NSView _recursiveDisplayDescendantsInRect:] + 509 12 com.apple.AppKit 0x00007fff39bacd89 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2302 13 com.apple.AppKit 0x00007fff39d4b61c -[NSView _recursiveDisplaySelfAndDescendantsInRect:] + 61 14 com.apple.AppKit 0x00007fff39d3a894 -[NSView _recursiveDisplayDescendantsInRect:] + 509 15 com.apple.AppKit 0x00007fff39bacd89 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2302 16 com.apple.AppKit 0x00007fff39d4b61c -[NSView _recursiveDisplaySelfAndDescendantsInRect:] + 61 17 com.apple.AppKit 0x00007fff39d3a894 -[NSView _recursiveDisplayDescendantsInRect:] + 509 18 com.apple.AppKit 0x00007fff39bacd89 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2302 19 com.apple.AppKit 0x00007fff39b62656 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 938 20 com.apple.AppKit 0x00007fff3a2cd4e0 -[NSView _oldDisplayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 2051 21 com.apple.AppKit 0x00007fff39b60e5d -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 253 22 com.apple.AppKit 0x00007fff39cb0b54 -[NSView displayIfNeededInRectIgnoringOpacity:] + 700 23 com.apple.AppKit 0x00007fff39cb088c -[NSView displayRectIgnoringOpacity:] + 154 24 com.apple.WebCore 0x000000011c0e7b3f WebCore::Widget::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy) + 607 (WidgetMac.mm:216) 25 com.apple.WebCore 0x000000011d95cbb3 WebCore::ScrollView::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy) + 83 (ScrollView.cpp:1188) 26 com.apple.WebCore 0x000000011e160a24 WebCore::RenderWidget::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 948 (RenderWidget.cpp:250) 27 com.apple.WebCore 0x000000011e1612f9 WebCore::RenderWidget::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 1241 (RenderWidget.cpp:304) 28 com.apple.WebCore 0x000000011df66c93 WebCore::paintPhase(WebCore::RenderElement&, WebCore::PaintPhase, WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 83 (RenderElement.cpp:1016) 29 com.apple.WebCore 0x000000011df66c14 WebCore::RenderElement::paintAsInlineBlock(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 244 (RenderElement.cpp:1030) 30 com.apple.WebCore 0x000000011de52cf0 WebCore::InlineElementBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) + 304 (InlineElementBox.cpp:82) 31 com.apple.WebCore 0x000000011de5bd95 WebCore::InlineFlowBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) + 1317 (InlineFlowBox.cpp:1218) 32 com.apple.WebCore 0x000000011e1639d4 WebCore::RootInlineBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) + 84 (RootInlineBox.cpp:169) 33 com.apple.WebCore 0x000000011e06c827 WebCore::RenderLineBoxList::paint(WebCore::RenderBoxModelObject*, WebCore::PaintInfo&, WebCore::LayoutPoint const&) const + 2023 (RenderLineBoxList.cpp:262) 34 com.apple.WebCore 0x000000011deddaff WebCore::RenderBlockFlow::paintInlineChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 287 (RenderBlockFlow.cpp:3548) 35 com.apple.WebCore 0x000000011dea9051 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 129 (RenderBlock.cpp:1124) 36 com.apple.WebCore 0x000000011deaa113 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 1075 (RenderBlock.cpp:1281) 37 com.apple.WebCore 0x000000011dea8846 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 246 (RenderBlock.cpp:1104) 38 com.apple.WebCore 0x000000011dea965e WebCore::RenderBlock::paintChild(WebCore::RenderBox&, WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool, WebCore::RenderBlock::PaintBlockType) + 1054 (RenderBlock.cpp:1181) 39 com.apple.WebCore 0x000000011dea920e WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool) + 126 (RenderBlock.cpp:1144) 40 com.apple.WebCore 0x000000011dea9160 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 400 (RenderBlock.cpp:1139) 41 com.apple.WebCore 0x000000011deaa113 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 1075 (RenderBlock.cpp:1281) 42 com.apple.WebCore 0x000000011dea8846 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 246 (RenderBlock.cpp:1104) 43 com.apple.WebCore 0x000000011e014ea7 WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) + 695 (RenderLayer.cpp:5022) 44 com.apple.WebCore 0x000000011e012a17 WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) + 1463 (RenderLayer.cpp:4997) 45 com.apple.WebCore 0x000000011e00eced WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 3453 (RenderLayer.cpp:4593) 46 com.apple.WebCore 0x000000011e00defc WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 444 (RenderLayer.cpp:4315) 47 com.apple.WebCore 0x000000011e00ce52 WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 1186 (RenderLayer.cpp:4297) 48 com.apple.WebCore 0x000000011e00c069 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 345 (RenderLayer.cpp:4236) 49 com.apple.WebCore 0x000000011e012437 WebCore::RenderLayer::paintList(WebCore::RenderLayer::LayerList, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 199 (RenderLayer.cpp:4717) 50 com.apple.WebCore 0x000000011e00edf9 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 3721 (RenderLayer.cpp:4609) 51 com.apple.WebCore 0x000000011e00defc WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 444 (RenderLayer.cpp:4315) 52 com.apple.WebCore 0x000000011e00ce52 WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 1186 (RenderLayer.cpp:4297) 53 com.apple.WebCore 0x000000011e00c069 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 345 (RenderLayer.cpp:4236) 54 com.apple.WebCore 0x000000011e00bd5e WebCore::RenderLayer::paint(WebCore::GraphicsContext&, WebCore::LayoutRect const&, WebCore::LayoutSize const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>, WebCore::RenderLayer::SecurityOriginPaintPolicy) + 382 (RenderLayer.cpp:4096) 55 com.apple.WebCore 0x000000011d74c6e4 WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy) + 1588 (FrameView.cpp:4203) 56 com.apple.WebKitLegacy 0x000000011079911c -[WebFrame(WebInternal) _drawRect:contentsOnly:] + 1340 (WebFrame.mm:662) 57 com.apple.WebKitLegacy 0x00000001107be58d -[WebHTMLView drawSingleRect:] + 813 (WebHTMLView.mm:3893) 58 com.apple.WebKitLegacy 0x00000001107beccb -[WebHTMLView drawRect:] + 635 (WebHTMLView.mm:3964) 59 com.apple.AppKit 0x00007fff3a2cbf29 _NSViewDrawRect + 83 60 com.apple.AppKit 0x00007fff39b6473c -[NSView _drawRect:clip:] + 1819 61 com.apple.AppKit 0x00007fff39b63598 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 4844 62 com.apple.WebKitLegacy 0x00000001107b11e5 -[WebHTMLView(WebPrivate) _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 485 (WebHTMLView.mm:1622) 63 com.apple.AppKit 0x00007fff39b62ec5 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 3097 64 com.apple.AppKit 0x00007fff39b62ec5 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 3097 65 com.apple.AppKit 0x00007fff39b62ec5 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 3097 66 com.apple.AppKit 0x00007fff39b62ec5 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 3097 67 com.apple.AppKit 0x00007fff39b62ec5 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 3097 68 com.apple.AppKit 0x00007fff39b62ec5 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 3097 69 com.apple.AppKit 0x00007fff3a2cd4e0 -[NSView _oldDisplayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 2051 70 com.apple.AppKit 0x00007fff39b60e5d -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 253 71 com.apple.AppKit 0x00007fff39b5d0b4 -[NSView displayIfNeeded] + 1581 72 com.apple.AppKit 0x00007fff39b5ca52 -[NSWindow displayIfNeeded] + 321 73 com.apple.AppKit 0x00007fff39c097ed _handleWindowNeedsDisplayOrLayoutOrUpdateConstraints + 868 74 com.apple.AppKit 0x00007fff3a2e8352 __83-[NSWindow _postWindowNeedsDisplayOrLayoutOrUpdateConstraintsUnlessPostingDisabled]_block_invoke.1507 + 46 75 com.apple.CoreFoundation 0x00007fff3c4aaf87 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 76 com.apple.CoreFoundation 0x00007fff3c4aaeaf __CFRunLoopDoObservers + 511 77 com.apple.CoreFoundation 0x00007fff3c48d978 __CFRunLoopRun + 1240 78 com.apple.CoreFoundation 0x00007fff3c48d207 CFRunLoopRunSpecific + 487 79 DumpRenderTree 0x0000000108655f69 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 7865 (DumpRenderTree.mm:2104) 80 DumpRenderTree 0x0000000108653fff runTestingServerLoop() + 447 (DumpRenderTree.mm:1216) 81 DumpRenderTree 0x000000010865348e dumpRenderTree(int, char const**) + 1646 (DumpRenderTree.mm:1331) 82 DumpRenderTree 0x00000001086569ff DumpRenderTreeMain(int, char const**) + 111 (DumpRenderTree.mm:1450) 83 DumpRenderTree 0x00000001086eb162 main + 34 (DumpRenderTreeMain.mm:34) 84 libdyld.dylib 0x00007fff6443c015 start + 1
Alexey Proskuryakov
Comment 3 2019-11-10 15:57:16 PST
It feels like we're hitting noticeably more !needsLayout() assertions on various tests than before.
Note You need to log in before you can comment on or make changes to this bug.