Bug 203994 - [GTK] WebDriver: implement new window command
Summary: [GTK] WebDriver: implement new window command
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2019-11-08 06:07 PST by Carlos Garcia Campos
Modified: 2019-11-12 00:13 PST (History)
7 users (show)

See Also:

Patch (30.82 KB, patch)
2019-11-08 06:44 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (32.18 KB, patch)
2019-11-11 02:45 PST, Carlos Garcia Campos
clopez: review+
clopez: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-11-08 06:07:21 PST
11.5 New Window
Comment 1 Carlos Garcia Campos 2019-11-08 06:08:31 PST
Adding GTK since this requires new API.
Comment 2 Carlos Garcia Campos 2019-11-08 06:44:22 PST
Created attachment 383122 [details]

This patch includes unit tests for the new GLib API, but we don'tm have WebDriver tests for the new window command in WebKit tree yet. I've run wpt tests and all pass. I'll update the imported wpt tests in WebKit after landing this.
Comment 3 EWS Watchlist 2019-11-08 06:45:25 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Carlos Garcia Campos 2019-11-11 02:45:06 PST
Created attachment 383258 [details]
Comment 5 Carlos Alberto Lopez Perez 2019-11-11 13:33:53 PST
Comment on attachment 383258 [details]

I guess this needs a second review since it adds new public API.
Comment 6 Carlos Garcia Campos 2019-11-12 00:12:47 PST
Committed r252356: <https://trac.webkit.org/changeset/252356>
Comment 7 Radar WebKit Bug Importer 2019-11-12 00:13:15 PST