The events are defined in https://w3c.github.io/picture-in-picture/. We want the WebKit prefix version of the picture-in-picture API also fires these events.
<rdar://problem/57011418>
Created attachment 383152 [details] Patch
Created attachment 383159 [details] Rebase the patch
Comment on attachment 383159 [details] Rebase the patch View in context: https://bugs.webkit.org/attachment.cgi?id=383159&action=review > Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h:91 > +void providePictureInPictureTo(HTMLVideoElement&); I thinks this would be better as a static method on HTMLVideoElementPictureInPicture than as a free function.
Comment on attachment 383159 [details] Rebase the patch View in context: https://bugs.webkit.org/attachment.cgi?id=383159&action=review >> Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h:91 >> +void providePictureInPictureTo(HTMLVideoElement&); > > I thinks this would be better as a static method on HTMLVideoElementPictureInPicture than as a free function. Right! Will update that.
Created attachment 383171 [details] Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 383171 [details]: inspector/model/remote-object-weak-collection.html bug 204016 (authors: drousso@apple.com and joepeck@webkit.org) The commit-queue is continuing to process your patch.
Comment on attachment 383171 [details] Patch for landing Clearing flags on attachment: 383171 Committed r252276: <https://trac.webkit.org/changeset/252276>
All reviewed patches have been landed. Closing bug.