Bug 203965 - Web Inspector: http/tests/inspector/target/target-events-for-provisional-page.html is flaky when running with other tests
Summary: Web Inspector: http/tests/inspector/target/target-events-for-provisional-page...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
Keywords: InRadar
Depends on: 203981
  Show dependency treegraph
Reported: 2019-11-07 09:53 PST by Yury Semikhatsky
Modified: 2019-11-07 16:02 PST (History)
6 users (show)

See Also:

Patch (1.63 KB, patch)
2019-11-07 14:48 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2019-11-07 09:53:12 PST

added in https://trac.webkit.org/changeset/251494/webkit

is a flakey failure when running with other tests.

Probable cause:

Some side effect of previous tests that disable PSON.

Flakiness Dashboard:

Comment 1 Yury Semikhatsky 2019-11-07 09:58:45 PST
The test reliably fails when running after  http/tests/dom/new-window-can-target-opener.html.

Tools/Scripts/run-webkit-tests --no-show-results --no-retry-failures --child-processes=1 http/tests/dom/new-window-can-target-opener.html http/tests/inspector/target/target-events-for-provisional-page.html
Comment 2 Radar WebKit Bug Importer 2019-11-07 10:50:18 PST
Comment 3 Yury Semikhatsky 2019-11-07 14:36:46 PST
The problem is that new-window-can-target-opener-win.html opened in a child window calls open() on its opener window, i.e. the test page itself (new-window-can-target-opener.html). It in turn triggers Page::setOpenedByDOMWithOpener() on the parent page. The next test will reuse the same instance of PlatformWebView and consequently the same Page in the WebProcess. Since instance of the page is the same it still has Page::openedByDOMWithOpener() == true. Because of that[1] cross-origin navigation in the next test page will reuse same process. I don't know if this is intentional behavior.

I'm going to add 
<!-- webkit-test-runner [ enableProcessSwapOnWindowOpen=true ] -->
as a temporary workaround for the flaky inspector test but we should probably never reuse a page which was openedByDOM.

[1] https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/UIProcess/WebProcessPool.cpp?rev=252014#L2139

[2] https://trac.webkit.org/browser/webkit/trunk/LayoutTests/http/tests/dom/resources/new-window-can-target-opener-win.html#L19
Comment 4 Yury Semikhatsky 2019-11-07 14:48:29 PST
Created attachment 383075 [details]
Comment 5 Devin Rousso 2019-11-07 15:04:47 PST
Comment on attachment 383075 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=383075&action=review


> LayoutTests/ChangeLog:11
> +        that may run before (the test may reuse Page instance from the previous test on which
> +        Page::openedByDOMWithOpener==true).

This seems like a bug.  Can you file a separate bug to fix this please?
Comment 6 Yury Semikhatsky 2019-11-07 15:39:40 PST
Filed https://bugs.webkit.org/show_bug.cgi?id=203981
Comment 7 WebKit Commit Bot 2019-11-07 15:45:02 PST
Comment on attachment 383075 [details]

Clearing flags on attachment: 383075

Committed r252214: <https://trac.webkit.org/changeset/252214>
Comment 8 WebKit Commit Bot 2019-11-07 15:45:04 PST
All reviewed patches have been landed.  Closing bug.