Bug 203963 – Port ServiceWorkerContainer to the HTML5 event loop

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Chris Dumez]

Port ServiceWorkerContainer to the HTML5 event loop.

[Chris Dumez]

Created attachment 383058 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 383058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383058&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.h:145
> +    bool m_shouldDeferMessageEvents { false };
> +    Vector<Ref<Event>> m_deferredMessageEvents;

Hm... how does GC keep wrappers for objects held by this event alive?

[Chris Dumez]

(In reply to Ryosuke Niwa from comment #2)
> Comment on attachment 383058 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383058&action=review
> 
> > Source/WebCore/workers/service/ServiceWorkerContainer.h:145
> > +    bool m_shouldDeferMessageEvents { false };
> > +    Vector<Ref<Event>> m_deferredMessageEvents;
> 
> Hm... how does GC keep wrappers for objects held by this event alive?

I don't think we have any logic to keep those wrappers alive currently. This is not a regression in this patch though.

[Ryosuke Niwa]

(In reply to Chris Dumez from comment #3)
> (In reply to Ryosuke Niwa from comment #2)
> > Comment on attachment 383058 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=383058&action=review
> > 
> > > Source/WebCore/workers/service/ServiceWorkerContainer.h:145
> > > +    bool m_shouldDeferMessageEvents { false };
> > > +    Vector<Ref<Event>> m_deferredMessageEvents;
> > 
> > Hm... how does GC keep wrappers for objects held by this event alive?
> 
> I don't think we have any logic to keep those wrappers alive currently. This
> is not a regression in this patch though.

Okay, sounds like a bug we should track somewhere. How do we track these bugs for service workers?

[Chris Dumez]

(In reply to Ryosuke Niwa from comment #4)
> (In reply to Chris Dumez from comment #3)
> > (In reply to Ryosuke Niwa from comment #2)
> > > Comment on attachment 383058 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=383058&action=review
> > > 
> > > > Source/WebCore/workers/service/ServiceWorkerContainer.h:145
> > > > +    bool m_shouldDeferMessageEvents { false };
> > > > +    Vector<Ref<Event>> m_deferredMessageEvents;
> > > 
> > > Hm... how does GC keep wrappers for objects held by this event alive?
> > 
> > I don't think we have any logic to keep those wrappers alive currently. This
> > is not a regression in this patch though.
> 
> Okay, sounds like a bug we should track somewhere. How do we track these
> bugs for service workers?

It is unclear to me at this point that we want to keep those wrappers alive though. You're talking about wrappers to MessagePorts I assume?

[Ryosuke Niwa]

(In reply to Chris Dumez from comment #5)
> (In reply to Ryosuke Niwa from comment #4)
> > (In reply to Chris Dumez from comment #3)
> > > (In reply to Ryosuke Niwa from comment #2)
> > > > Comment on attachment 383058 [details]
> > > > Patch
> > > > 
> > > > View in context:
> > > > https://bugs.webkit.org/attachment.cgi?id=383058&action=review
> > > > 
> > > > > Source/WebCore/workers/service/ServiceWorkerContainer.h:145
> > > > > +    bool m_shouldDeferMessageEvents { false };
> > > > > +    Vector<Ref<Event>> m_deferredMessageEvents;
> > > > 
> > > > Hm... how does GC keep wrappers for objects held by this event alive?
> > > 
> > > I don't think we have any logic to keep those wrappers alive currently. This
> > > is not a regression in this patch though.
> > 
> > Okay, sounds like a bug we should track somewhere. How do we track these
> > bugs for service workers?
> 
> It is unclear to me at this point that we want to keep those wrappers alive
> though. You're talking about wrappers to MessagePorts I assume?

Yeah, MessagePorts and other transferred objects. Because you can postMessage to yourself, or some other window, right? In those cases, it's totally observable as to whether the wrapper has changed or not.

[WebKit Commit Bot]

Comment on attachment 383058 [details]
Patch

Clearing flags on attachment: 383058

Committed r252206: <https://trac.webkit.org/changeset/252206>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56998897>