Bug 203962 - Make DownloadID an ObjectIdentifier
Summary: Make DownloadID an ObjectIdentifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-07 09:30 PST by Alex Christensen
Modified: 2020-10-05 16:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (26.92 KB, patch)
2019-11-07 09:33 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (27.31 KB, patch)
2019-11-07 14:27 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (339.31 KB, patch)
2020-10-05 14:35 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (35.25 KB, patch)
2020-10-05 14:36 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (35.08 KB, patch)
2020-10-05 15:26 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (34.69 KB, patch)
2020-10-05 15:42 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (35.21 KB, patch)
2020-10-05 16:31 PDT, Alex Christensen 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-11-07 09:30:35 PST 
Make DownloadID an ObjectIdentifier
Comment 1 Alex Christensen 2019-11-07 09:33:09 PST 
Created attachment 383057 [details]
Patch
Comment 2 Chris Dumez 2019-11-07 10:20:39 PST 
Looks like there are some build issues.
Comment 3 Alex Christensen 2019-11-07 14:27:50 PST 
Created attachment 383072 [details]
Patch
Comment 4 youenn fablet 2019-11-08 06:47:23 PST 
Comment on attachment 383072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383072&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1970
> +    downloadProxyConnection()->send(Messages::DownloadProxy::DidCancel({ }), downloadID.toUInt64());

We can probably remove toUInt64() here and in every send() call site below.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1975
> +    uint64_t destinationID = networkDataTask.pendingDownloadID().toUInt64();

auto destinationID = networkDataTask.pendingDownloadID(); or directly inline the call where used.
Comment 5 Alex Christensen 2019-11-08 13:35:05 PST 
http://trac.webkit.org/r252260
Comment 6 Radar WebKit Bug Importer 2019-11-08 13:36:16 PST 
<rdar://problem/57032761>
Comment 7 Jonathan Bedard 2019-11-08 16:20:06 PST 
Reverted r252260 for reason:

Breaks half of API tests

Committed r252274: <https://trac.webkit.org/changeset/252274>
Comment 8 Jonathan Bedard 2019-11-08 16:21:02 PST 
My rollout was a bit blind, but given how conclusive https://results.webkit.org/suites?suite=api-tests was, I thought justified. Seems like this breaks Debug API tests
Comment 9 Alex Christensen 2020-10-05 14:34:13 PDT 
That was a case of sending a default-constructed DownloadID instead of using an Optional<DownloadID> and sending nullopt.  Will fix and rebase.
Comment 10 Alex Christensen 2020-10-05 14:35:07 PDT 
Created attachment 410560 [details]
Patch
Comment 11 Alex Christensen 2020-10-05 14:36:22 PDT 
Created attachment 410562 [details]
Patch
Comment 12 Alex Christensen 2020-10-05 15:26:02 PDT 
Created attachment 410569 [details]
Patch
Comment 13 Alex Christensen 2020-10-05 15:42:11 PDT 
Created attachment 410573 [details]
Patch
Comment 14 Alex Christensen 2020-10-05 16:31:12 PDT 
Created attachment 410585 [details]
Patch
Comment 15 Geoffrey Garen 2020-10-05 16:36:03 PDT 
Comment on attachment 410585 [details]
Patch

r=me
Comment 16 Alex Christensen 2020-10-05 16:53:46 PDT 
http://trac.webkit.org/r268017