Bug 203962 - Make DownloadID an ObjectIdentifier
Summary: Make DownloadID an ObjectIdentifier
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-07 09:30 PST by Alex Christensen
Modified: 2019-11-08 16:21 PST (History)
4 users (show)

See Also:


Attachments
Patch (26.92 KB, patch)
2019-11-07 09:33 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (27.31 KB, patch)
2019-11-07 14:27 PST, Alex Christensen
youennf: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-11-07 09:30:35 PST
Make DownloadID an ObjectIdentifier
Comment 1 Alex Christensen 2019-11-07 09:33:09 PST
Created attachment 383057 [details]
Patch
Comment 2 Chris Dumez 2019-11-07 10:20:39 PST
Looks like there are some build issues.
Comment 3 Alex Christensen 2019-11-07 14:27:50 PST
Created attachment 383072 [details]
Patch
Comment 4 youenn fablet 2019-11-08 06:47:23 PST
Comment on attachment 383072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383072&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1970
> +    downloadProxyConnection()->send(Messages::DownloadProxy::DidCancel({ }), downloadID.toUInt64());

We can probably remove toUInt64() here and in every send() call site below.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1975
> +    uint64_t destinationID = networkDataTask.pendingDownloadID().toUInt64();

auto destinationID = networkDataTask.pendingDownloadID(); or directly inline the call where used.
Comment 5 Alex Christensen 2019-11-08 13:35:05 PST
http://trac.webkit.org/r252260
Comment 6 Radar WebKit Bug Importer 2019-11-08 13:36:16 PST
<rdar://problem/57032761>
Comment 7 Jonathan Bedard 2019-11-08 16:20:06 PST
Reverted r252260 for reason:

Breaks half of API tests

Committed r252274: <https://trac.webkit.org/changeset/252274>
Comment 8 Jonathan Bedard 2019-11-08 16:21:02 PST
My rollout was a bit blind, but given how conclusive https://results.webkit.org/suites?suite=api-tests was, I thought justified. Seems like this breaks Debug API tests